chore: BREAKING use waitForResource util function
#1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laurin-W
force-pushed
the
chore/improve-awaitCreateComplete-action
branch
from
9fe4954
to
2c34796
Compare
srosset81
requested changes
Sep 29, 2023
There was a problem hiding this comment.
Since removing the activitypub.object.awaitCreateComplete is a breaking change, it should be merged on the next branch. (You should also indicate breaking changes in the PR description). This way we will be in sync with your other PR (activitypods/activitypods#89) which points also to the next branch.
src/middleware/packages/activitypub/services/activitypub/subservices/actor.js
Show resolved
Hide resolved
src/middleware/packages/activitypub/services/activitypub/subservices/object.js
Outdated
Show resolved
Hide resolved
src/middleware/packages/ldp/services/resource/actions/awaitCreateComplete.js
Outdated
Show resolved
Hide resolved
for `activitypub.actor` and `activitypub.object` `awaitCreateComplete`
Laurin-W
force-pushed
the
chore/improve-awaitCreateComplete-action
branch
from
2c34796
to
f598f2d
Compare
Laurin-W
changed the title
waitForResource util functionwaitForResource util function
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for
activitypub.actorandactivitypub.objectawaitCreateCompleteAs suggested by @srosset81 in activitypods/activitypods#87 (comment).
I made a small change compared to the original: Instead of checking, if the required fields are undefined
result[key] === undefined, I adopted your original check usingObject.keys(result).includesBreaking changes⚠️
activitypub.object.awaitCreateCompletehas been replaced withldp.resource.awaitCreateComplete