Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return 201 when upload finish (and not before) and 500 if upload fail #844

Merged

Conversation

simonLouvet
Copy link
Contributor

@simonLouvet simonLouvet commented Sep 8, 2021

POST image returned uri before file uploaded création finish.

Condition to reproduce :

  • downgrade packet loss in local loop : sudo tc qdisc add dev lo root netem loss 30%
  • downgrade latency and upload rate thanks to thottling in chrome dev tool

Promise wrapper and await now googdmanage response

@vercel
Copy link

vercel bot commented Sep 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

website – ./website

🔍 Inspect: https://vercel.com/semapps/website/4Y39W5SnS5EWjr4DgVHKRRwjEjRM
✅ Preview: Canceled

[Deployment for a5569bd canceled]

archipel – ./src/frontend

🔍 Inspect: https://vercel.com/semapps/archipel/zjQamH7aPqeQu6xs6nHm7YWhRorB
✅ Preview: https://archipel-git-821return201whenuploadfinishand500i-d8a9f1-semapps.vercel.app

@simonLouvet
Copy link
Contributor Author

simonLouvet commented Sep 8, 2021

resoud egalement la #576. Le fichier ne devait pas être correctement finalisé à l'upload.

@simonLouvet
Copy link
Contributor Author

resolve #576

Copy link
Contributor

@srosset81 srosset81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top, merci !

@simonLouvet simonLouvet merged commit 40f11d5 into master Sep 10, 2021
@srosset81 srosset81 deleted the 821_return_201_when_upload_finish_and_500_if_upload_fail branch September 10, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug de chargement des images dans Archipel / serveur GL
2 participants