Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Short-hand predicates #2

Closed
epage opened this issue May 28, 2018 · 1 comment
Closed

Short-hand predicates #2

epage opened this issue May 28, 2018 · 1 comment
Labels
breaking-change enhancement Improve the expected
Milestone
1.0

Comments

@epage
Copy link
Contributor

epage commented May 28, 2018 •
edited

  • code: take IntoCodePredicate
    • From<i32>
    • From<Predicate<i32>>
  • stdin / stdout: take IntoOutputPredicate
    • From<str>
    • From<Predicate<str>>
    • From<[u8]>
@epage epage added the enhancement Improve the expected label May 28, 2018
epage added a commit that referenced this issue May 29, 2018
@epage
feat: Short-hand Assert::code
b3450b8 
Part of #2
@epage epage added this to the 1.0 milestone May 29, 2018
@epage
Copy link
Contributor Author

epage commented May 29, 2018

I'm marking as a breaking change out of concern because these kind of concrete API to conversion API changes have broken others in the past.

epage added a commit that referenced this issue May 30, 2018
@epage
feat: Short-hand Assert::code
e234685 
Part of #2
@epage epage mentioned this issue Jun 13, 2018
Merged
epage added a commit to epage/assert_fs that referenced this issue Jun 14, 2018
@epage
feat(assert): Predicate<[u8]> acts on file contents
43ec578 
This is based on similar work for assert_cmd, see
assert-rs/assert_cmd#2.

BREAKING CHANGE: `assert` now takes a predicate by ownership.
epage referenced this issue in epage/assert_cmd Jun 16, 2018
@epage
feat(assert): Short-hand output predicates
43eceba 
Fixes #2

BREAKING CHANGE: `stdout` / `stderr` now take a predicate by ownership.
@epage epage mentioned this issue Jun 16, 2018
Merged
@epage epage closed this as completed in #14 Jun 16, 2018
@epage epage mentioned this issue Jun 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change enhancement Improve the expected
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@epage