-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Powershell runtime support #41
base: main
Are you sure you want to change the base?
Conversation
…cause of `using` statement
path, | ||
home, | ||
config: config_path, | ||
timeout: Duration::from_millis(50), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting the timeout is 50ms will get nothing in comptest
function.
Because
completest/crates/completest-pty/src/lib.rs
Line 495 in 4334bff
while let Ok(n) = stream.read(&mut buf) { |
the read call is slow for powershell.
I've been working on test code to test support for PowerShell in
I found a possibly related issue in the PowerShell community: PowerShell/PowerShell#14932 |
// Open the original file and read its content | ||
let mut original_file = OpenOptions::new().read(true).open(&file_path)?; | ||
let mut original_content = Vec::new(); | ||
original_file.read_to_end(&mut original_content)?; |
Check failure
Code scanning / clippy
use of File::read_to_end Error
// Open the original file and read its content | ||
let mut original_file = OpenOptions::new().read(true).open(&file_path)?; | ||
let mut original_content = Vec::new(); | ||
original_file.read_to_end(&mut original_content)?; |
Check failure
Code scanning / clippy
use of File::read_to_end Error
Pull Request Test Coverage Report for Build 9790909347Details
💛 - Coveralls |
I have mixed feelings. Most devs will be on Linux so this makes it easy to not regress. However, most contributors to this feature will likely be on Windows and won't be able to test it.
sigh automatically closed issues. |
Most people definitely use PowerShell on Windows. Since I'm developing on Linux, my plan is to first support PowerShell on Linux to add tests for PowerShell support in clap_complete. I'll definitely need to support PowerShell on Windows later on. |
To support powershell completion test