Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm audit complaints #628

Open
papandreou opened this issue Oct 14, 2018 · 6 comments
Open

npm audit complaints #628

papandreou opened this issue Oct 14, 2018 · 6 comments

Comments

@XhmikosR
Copy link

XhmikosR commented Mar 3, 2019

@papandreou: these are fixed upstream. Can you update the packages and release a new version?

@XhmikosR
Copy link

XhmikosR commented Mar 3, 2019

BTW please don't lock down the versions. If a patch release is made, you need to release a new version yourself too, which is bad. Just use a semver operator that fits your needs.

@papandreou
Copy link
Member Author

Thanks for the heads up! I've been through all of them now, released new versions of the wrappers I maintain, and updated assetgraph-builder to them.

There are still some dependencies on the old versions via the express-processimage dependency. I expect that to be sorted out shortly.

@XhmikosR
Copy link

XhmikosR commented Mar 4, 2019

Thnaks! I think you missed a few deps from adding a sevmver operator like assetgraph.

Waiting for the express-processimage fixes :)

@papandreou
Copy link
Member Author

I think you missed a few deps from adding a sevmver operator like assetgraph.

Yeah, that is intentional. The two projects are intimately connected, and whenever we make radical changes to assetgraph (such as replacing the JavaScript parser in yesterday's minor release), there's often breakage in the assetgraph-builder test suite. It's stuff that doesn't matter externally (or we'd make a major version bump), but I've come to prefer to do the updates in a handheld way.

Waiting for the express-processimage fixes :)

It seems like the project is in a bit of a bad state due to some recent changes to streams in node 10, but we'll get it sorted out.

@papandreou
Copy link
Member Author

Sorted out the express-processimage situation now and released 6.9.1. We're down only low and moderate ones now:

found 12 vulnerabilities (6 low, 6 moderate)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants