-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump bin-wrapper to version 4 #89
Conversation
It doesn't work as a minor release pngquant-bin returns a BinWrapper, and bin-wrapper 4.x changes the public api. That's at least part of why the post-installs script is failing. |
Test fails because of this bug: kevva/bin-wrapper#69 While bin-wrapper's public API did change, this module only returns the path. Thus no breaking change. Lines 1 to 2 in 30d0f40
|
any progress here, or do we need to wait for kevva/bin-wrapper#69 ? |
kevva/bin-wrapper#69 was merged in version 4.0.1 |
@realityking |
I just opened a new PR #95 with new |
Fixed on #95, sorry 😢 |
This should be good as a minor release.