-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add docker image support #147
Conversation
I don't know how Docker works, but I don't see the harm in pulling this in, either. Hopefully we'll remember to keep the instructions up-to-date. |
The short version is that if you enable automated builds, every time you push to github it will clone your project and run the |
That sounds really nifty. @Munter @gustavnikolaj Any objections to merging this? |
Oh, that's nice. I've never used docker before, but I can see how that would be good for avoiding needing to install the non-npm based deps. Also, wouldn't that (indirectly) give us windows support via Boot2Docker? |
It sounds awesome. |
Thumbs up for docker images. This might also really help us with those pesky operating system level dependencies that people usually run into |
Great, merging. |
@saulshanabrook How do I enable automated builds? |
Done: https://registry.hub.docker.com/u/assetgraph/assetgraph-builder/ I've created assetgraph as an organization. Ping me with your respective accounts and I'll figure out how to add them |
@Munter I just registered as papandreou. |
Added to the org |
@saulshanabrook Is there anything more we need to do? None of us are actually using this docker container ourselves, so we're relying on you to tell us if we did something wrong in our setup atm :) |
Instead of installing this project locally, I created a
Dockerfile
which builds an image that has everything ready to use. This is helpful to me because then I don't have to worry about installing and dependencies on my local system, I only need Docker installed correctly.All you have to do is create a
assetgraph-builder
image on the Docker Hub and turn on automated buildsLet me know if you have any questions.