Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docker image support #147

Merged
merged 1 commit into from
Nov 24, 2014

Conversation

saulshanabrook
Copy link
Contributor

Instead of installing this project locally, I created a Dockerfile which builds an image that has everything ready to use. This is helpful to me because then I don't have to worry about installing and dependencies on my local system, I only need Docker installed correctly.

All you have to do is create a assetgraph-builder image on the Docker Hub and turn on automated builds

Let me know if you have any questions.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling a03b592 on saulshanabrook:feature/docker into fa905e9 on assetgraph:master.

@papandreou
Copy link
Member

I don't know how Docker works, but I don't see the harm in pulling this in, either. Hopefully we'll remember to keep the instructions up-to-date.

@saulshanabrook
Copy link
Contributor Author

The short version is that if you enable automated builds, every time you push to github it will clone your project and run the Dockerfile to create an image. That image is stored on their server. Then when I am on my computer and run docker run --rm -it -v "$(pwd)":/app/ -w /app/ assetgraph-builder path/to/your/index.html --outroot path/to/output/directory it will download that image and share a directory with it and run buildProduction path/to/your/index.html --outroot path/to/output/directory in it.

@papandreou
Copy link
Member

That sounds really nifty.

@Munter @gustavnikolaj Any objections to merging this?

@notslang
Copy link
Member

Oh, that's nice. I've never used docker before, but I can see how that would be good for avoiding needing to install the non-npm based deps. Also, wouldn't that (indirectly) give us windows support via Boot2Docker?

@gustavnikolaj
Copy link
Member

It sounds awesome.

@Munter
Copy link
Member

Munter commented Nov 24, 2014

Thumbs up for docker images. This might also really help us with those pesky operating system level dependencies that people usually run into

@papandreou
Copy link
Member

Great, merging.

papandreou added a commit that referenced this pull request Nov 24, 2014
@papandreou papandreou merged commit 4b2e0ae into assetgraph:master Nov 24, 2014
@papandreou
Copy link
Member

@saulshanabrook How do I enable automated builds?

@Munter
Copy link
Member

Munter commented Nov 24, 2014

Done: https://registry.hub.docker.com/u/assetgraph/assetgraph-builder/

I've created assetgraph as an organization. Ping me with your respective accounts and I'll figure out how to add them

@papandreou
Copy link
Member

@Munter I just registered as papandreou.

@Munter
Copy link
Member

Munter commented Nov 24, 2014

Added to the org

@Munter
Copy link
Member

Munter commented Nov 24, 2014

@saulshanabrook Is there anything more we need to do? None of us are actually using this docker container ourselves, so we're relying on you to tell us if we did something wrong in our setup atm :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants