Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clang-Tidy performance fixes (make values const-ref where needed). #4525

Merged
merged 1 commit into from May 12, 2022
Merged

Clang-Tidy performance fixes (make values const-ref where needed). #4525

merged 1 commit into from May 12, 2022

Conversation

Skylion007
Copy link
Contributor

  • Apply fixes from clang-tidy (mostly just ensuring that values that should use const ref end up doing so).

kimkulling
kimkulling approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@kimkulling kimkulling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, I will merge it!

@kimkulling kimkulling merged commit eeb524a into assimp:master May 12, 2022
@kimkulling
Copy link
Member

Merged, thanks a lot for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimkulling kimkulling kimkulling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Asset-Importer-Lib Development
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Skylion007 @kimkulling