Perfect forward val to utMaybe.cpp #4717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skylion007
force-pushed
the
perfect-forward-utMaybe
branch
2 times, most recently
from
6bfc929
to
5560646
Compare
Skylion007
force-pushed
the
perfect-forward-utMaybe
branch
from
5560646
to
20755f4
Compare
|
Not to worry! Thanks you so much for the great review. I will merge it. |
|
Merged, thanks a lot for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something I should have caught in my review of #4715 . The val arg should be perfectly forwarded with a universal reference to utMaybe. This allows the value T to be move assigned which allows both can make it more efficient and also allows utMaybe to work with values that are only move assignable. By using perfect forwarding, it will also just pass the reference if T is a reference.
Sorry for not catching this yesterday @kimkulling