Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized usedVertexIndices in JoinVerticesProcess by using bitmask instead of unordered_set #4901

Merged
merged 4 commits into from
Jan 31, 2023
Merged

Optimized usedVertexIndices in JoinVerticesProcess by using bitmask instead of unordered_set #4901

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
72b178b
Optimized usedVertexIndices by using bitmask instead of unordered_set
AdamCichocki Jan 23, 2023
5ed09b7
usedVertexIndicesMask is now based on vector<boo> instead of vector<u…
AdamCichocki Jan 23, 2023
d6b8d61
Merge branch 'master' into JoinVerticesProcessUsedVerticesMask
kimkulling Jan 30, 2023
5caae1a
Merge branch 'master' into JoinVerticesProcessUsedVerticesMask
kimkulling Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions code/PostProcessing/JoinVerticesProcess.cpp
View file
Open in desktop
Expand Up @@ -264,12 +264,12 @@ int JoinVerticesProcess::ProcessMesh( aiMesh* pMesh, unsigned int meshIndex) {
// We should care only about used vertices, not all of them
// (this can happen due to original file vertices buffer being used by
// multiple meshes)
std::unordered_set<unsigned int> usedVertexIndices;
usedVertexIndices.reserve(pMesh->mNumVertices);
for( unsigned int a = 0; a < pMesh->mNumFaces; a++) {
std::vector<bool> usedVertexIndicesMask;
usedVertexIndicesMask.resize(pMesh->mNumVertices, false);
for (unsigned int a = 0; a < pMesh->mNumFaces; a++) {
aiFace& face = pMesh->mFaces[a];
for( unsigned int b = 0; b < face.mNumIndices; b++) {
usedVertexIndices.insert(face.mIndices[b]);
for (unsigned int b = 0; b < face.mNumIndices; b++) {
usedVertexIndicesMask[face.mIndices[b]] = true;
}
}

Expand Down Expand Up @@ -335,7 +335,7 @@ int JoinVerticesProcess::ProcessMesh( aiMesh* pMesh, unsigned int meshIndex) {
int newIndex = 0;
for( unsigned int a = 0; a < pMesh->mNumVertices; a++) {
// if the vertex is unused Do nothing
if (usedVertexIndices.find(a) == usedVertexIndices.end()) {
if (!usedVertexIndicesMask[a]) {
continue;
}
// collect the vertex data
Expand Down