Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized usedVertexIndices in JoinVerticesProcess by using bitmask instead of unordered_set #4901

Merged
merged 4 commits into from Jan 31, 2023
Merged

Optimized usedVertexIndices in JoinVerticesProcess by using bitmask instead of unordered_set #4901

merged 4 commits into from Jan 31, 2023

Conversation

AdamCichocki
Copy link
Contributor

No description provided.

@turol
Copy link
Member

turol commented Jan 23, 2023

Do you have benchmarks?

@AdamCichocki
Copy link
Contributor Author

AdamCichocki commented Jan 23, 2023 •
edited

Cuts the JoinVertices time in half, while JoinVertices take almost half the time of the whole import of models with simple vertices (i.e. no tangents etc).

@AdamCichocki AdamCichocki changed the title Optimized usedVertexIndices by using bitmask instead of unordered_set Optimized usedVertexIndices in JoinVerticesProcess by using bitmask instead of unordered_set Jan 23, 2023
@Skylion007
Copy link
Contributor

Wouldn't the std::vector<bool> specialization be a bit more readable / helpful here? https://en.cppreference.com/w/cpp/container/vector_bool

@AdamCichocki
Copy link
Contributor Author

@Skylion007 Fair enough, updated the PR.

kimkulling
kimkulling approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@kimkulling kimkulling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, much better!

@kimkulling kimkulling merged commit b55e29b into assimp:master Jan 31, 2023
@kimkulling
Copy link
Member

Merged, thanks a lot for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@kimkulling kimkulling kimkulling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AdamCichocki @turol @Skylion007 @kimkulling