Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Half-Life 1 MDL importer bone hierarchy. #5007

Merged
merged 10 commits into from
Mar 16, 2023
Merged

Fix Half-Life 1 MDL importer bone hierarchy. #5007

merged 10 commits into from
Mar 16, 2023

Conversation

malortie
Copy link
Contributor

Fixes #5002.

@malortie malortie mentioned this pull request Mar 13, 2023
Closed
@malortie
Copy link
Contributor Author

@kimkulling

  1. You may use a Squash commit merge strategy to get all changes in a single commit.
  2. So far I had only included compiled MDL files and commited the source files to a separate repo. Would you like me to commit the source files to Assimp repo ?

kimkulling
kimkulling reviewed Mar 14, 2023
View reviewed changes
Copy link
Member

@kimkulling kimkulling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some minor findings. If you find the time to solve them by yourself I would really apprechiate this. If you don't have the time I can do this as well.
Thanks a lot for your help.

code/AssetLib/MDL/HalfLife/HL1MDLLoader.cpp Outdated Show resolved Hide resolved
test/unit/ImportExport/MDL/utMDLImporter_HL1_Nodes.cpp Outdated Show resolved Hide resolved
test/unit/ImportExport/MDL/utMDLImporter_HL1_Nodes.cpp Outdated Show resolved Hide resolved
test/unit/ImportExport/MDL/utMDLImporter_HL1_Nodes.cpp Show resolved Hide resolved
kimkulling
kimkulling approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@kimkulling kimkulling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thanks for the work!

@kimkulling kimkulling merged commit 5a4f7c0 into assimp:master Mar 16, 2023
@malortie malortie deleted the fix_hl1_mdl_importer_bone_hierarchy branch April 28, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turol turol turol approved these changes

@kimkulling kimkulling kimkulling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
The Asset-Importer-Lib Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Half-Life MDL broken bone hierarchy
3 participants
@malortie @turol @kimkulling