Fix malformed irr files #5182
Merged
Fix malformed irr files #5182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #5171
Historical note: at this time UTF16 IRR model loading is completely broken. The UTF16 files have been edited in lock-step with their UTF8 counterparts, but it was not possible to test the UTF16 files when this PR was submitted.
Changes in this PR
test/models/IRR/scenegraphAnim.irr
test/models/IRR/scenegraphAnim_UTF16LE.irr
Fix typo which was causing malformed xml. After this fix, the UTF8 file still fails to load due to Validation failed: Empty node animation channel
test/models/IRR/scenegraphAnimMod.irr
test/models/IRR/scenegraphAnimMod_UTF16LE.irr
New files which slightly modify the original 2 files:
The UTF8 test/models/IRR/scenegraphAnimMod.irr now successfully loads and contains cellar and dwarf meshes, plus a cube and two sphere primitives:
