Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5420 duplicate degrees to radians conversion in fbx importer #5427

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

Biohazard90
Copy link
Contributor

Fix #5420 incorrect angles being imported for FBX animations in specific cases.

Copy link
Member

@kimkulling kimkulling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@JulianKnodt
Copy link
Contributor

@Biohazard90 probably needs another rebase

@Biohazard90
Copy link
Contributor Author

@JulianKnodt @kimkulling alright done, should be good to be merged I think?

@kimkulling
Copy link
Member

Yes, I will merge it. CI is on its way!

@kimkulling kimkulling merged commit feb861f into assimp:master Mar 21, 2024
8 checks passed
@kimkulling
Copy link
Member

Merged, thanks a lot for your contrribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Bug: FBX Importer using wrong Angles in Animations
3 participants