Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add US phone number formatter #49

Merged
merged 1 commit into from
Mar 3, 2015

Conversation

svemir
Copy link
Contributor

@svemir svemir commented Mar 1, 2015

Added US phone formatter with a separate protractor test and a karma test, and a tweaked the gulp file to create a separate build file masks.us.js that only has the global masks and the new us phone mask.

There is probably a cleaner way to do the whole BR vs US thing, but for now I tried to do it in a way that leaves the existing stuff alone. Further splitting up can be done separately.

NOTE that I use element by id in protractor tests because by model and by bind seem to create warnings even in existing tests.

@coveralls
Copy link

Coverage Status

Coverage increased (+7.05%) to 25.84% when pulling 603bcac on Symplicity:us-phones into ea3f23f on assisrafael:master.

@assisrafael
Copy link
Owner

Nice!
I will take a merge it ASAP.

@assisrafael assisrafael merged commit 603bcac into assisrafael:master Mar 3, 2015
@assisrafael assisrafael mentioned this pull request Mar 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants