Fix nil pointer on device get-samples and payload parsing on device send-data #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddbbt
changed the title
Annopaolo
requested changes
Jan 26, 2024
cmd/appengine/device.go
Outdated
| @@ -808,6 +808,7 @@ func devicesGetSamplesF(command *cobra.Command, args []string) error { | |||
| fmt.Fprintf(os.Stderr, "You need to specify a valid path for interface %s\n", interfaceName) | |||
| os.Exit(1) | |||
| default: | |||
|
|
|||
There was a problem hiding this comment.
Nit: remove this empty line
eddbbt
force-pushed
the
errors_fix
branch
6 times, most recently
from
f425abe
to
8f3b707
Compare
Fix nil pointer error on appengine devices get-samples Signed-off-by: Eddy Babetto <eddy.babetto@secomind.com>
Fix error on command device send-data with array payload Signed-off-by: Eddy Babetto <eddy.babetto@secomind.com>
Annopaolo
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix of nil pointer error when running command device get-samples
Fix of payload parsing when sending an array through device send-data