Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Go to 1.21 #244

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

noaccOS
Copy link
Contributor

@noaccOS noaccOS commented Apr 9, 2024

update to the latest version of Go.

golangci-lint also needs to be updated for recent versions of Go.

@noaccOS noaccOS marked this pull request as draft April 9, 2024 10:27
@noaccOS noaccOS force-pushed the chore/go-1-22 branch 2 times, most recently from a9c429e to b1832ce Compare April 9, 2024 12:28
@noaccOS noaccOS changed the title chore: update go to 1.22 chore: update Go to 1.21 Apr 9, 2024
@noaccOS noaccOS marked this pull request as ready for review April 9, 2024 12:40
Copy link
Collaborator

@matt-mazzucato matt-mazzucato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about testing go 1.21 and 1.22 in CI, and use go 1.22 for releases?
Also, I'd like this PR to be rebased on master so that the new astartectl release will be backed by a fresher go version.

1.53 would fail with recent go versions

Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@noaccOS noaccOS changed the base branch from release-23.5 to master June 26, 2024 12:15
updates goreleaser-action to the latest version

goreleaser-action was already using `version: latest`, which was using
goreleaser v2 and crashed on release for incompatible configuration.

this formalizes that we're using v2 and locks the the dependency to v2
to avoid future breakage.

Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
Copy link
Collaborator

@matt-mazzucato matt-mazzucato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After our IRL discussion I think we can proceed as follows:

  • use go 1.21 everywhere
  • use go 1.22 only in CI to test the build with the next version

Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
@matt-mazzucato matt-mazzucato merged commit fdd5f4f into astarte-platform:master Jun 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants