-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update Go to 1.21 #244
chore: update Go to 1.21 #244
Conversation
a9c429e
to
b1832ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about testing go 1.21 and 1.22 in CI, and use go 1.22 for releases?
Also, I'd like this PR to be rebased on master so that the new astartectl release will be backed by a fresher go version.
1.53 would fail with recent go versions Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
updates goreleaser-action to the latest version goreleaser-action was already using `version: latest`, which was using goreleaser v2 and crashed on release for incompatible configuration. this formalizes that we're using v2 and locks the the dependency to v2 to avoid future breakage. Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After our IRL discussion I think we can proceed as follows:
- use go 1.21 everywhere
- use go 1.22 only in CI to test the build with the next version
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
update to the latest version of Go.
golangci-lint also needs to be updated for recent versions of Go.