Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IDs to binary systems in synthetic clusters #199

Closed
Gabriel-p opened this issue May 3, 2015 · 0 comments
Closed

Add IDs to binary systems in synthetic clusters #199

Gabriel-p opened this issue May 3, 2015 · 0 comments

Comments

@Gabriel-p
Copy link
Contributor

Gabriel-p commented May 3, 2015

Each star should be assigned integer IDs starting with 1 at first (when all stars in the sequence are generated), 2 to differentiate those below the magnitude cut (instead of discarding them entirely), 3 for those outside the mass limits, 4 for binaries, etc.

These isn't trivial and could increase significantly the time used by the synthetic cluster generation function.

This also complicates matters with binarity assignation (see #198), since keeping stars beyond the max-mag-cut means most stars selected to be binaries will be located beyond the max-mag-cut limit simply because most stars are located in the lower regions of the sequence.


The above is not necessary, provides no immediate benefit, and could disrupt the process of generating a synthetic cluster quite a bit.

Instead, add IDs to differentiate single stars from binaries.

@Gabriel-p Gabriel-p self-assigned this May 3, 2015
@Gabriel-p Gabriel-p added this to the v0.5.0 milestone May 3, 2015
@Gabriel-p Gabriel-p modified the milestones: v0.5.0, v0.2.0 May 14, 2015
@Gabriel-p Gabriel-p modified the milestones: v0.3.0, v0.2.0 Sep 6, 2015
@Gabriel-p Gabriel-p added Backlog and removed ready labels May 21, 2016
@Gabriel-p Gabriel-p modified the milestones: v0.2.0, v0.3.0 Oct 6, 2016
Gabriel-p added a commit that referenced this issue Nov 30, 2016
@Gabriel-p Gabriel-p changed the title Add IDs to stars in synthetic clusters Add IDs to binary systems in synthetic clusters Dec 1, 2016
@Gabriel-p Gabriel-p added Closed and removed Backlog labels Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant