Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong error curve fitting #338

Closed
4 tasks done
Gabriel-p opened this issue Aug 10, 2017 · 0 comments
Closed
4 tasks done

Wrong error curve fitting #338

Gabriel-p opened this issue Aug 10, 2017 · 0 comments
Assignees
Milestone

Comments

@Gabriel-p
Copy link
Contributor

Gabriel-p commented Aug 10, 2017

A couple of issues with error handling:

  • In the err_accpt_rejct function, if the manual mode was used, the max error value (stored in clp['err_max']) could be different from the one in the params file (stored in pd['err_max']). Yet, the err_range_avrg function uses the pd['err_max'] value rather than the possibly updated one.
  • If the manual mode is used and all stars are kept, the code stores the string all in clp['err_max']. This produces a crash later on when the synthetic clusters are produced.
  • The err_range_avrg function uses the raw error data read from file, instead of the cleaned data after the max error rejection performed in err_accpt_rejct (this appears to be a widespread issue)
  • The get_m_c_errors function (in err_range_avrg) uses err_max as a fitting point in the last resort fit ("2P exponential error function fit failed") This produces unrealistic error curves such as this one:

captura realizada el 2017-08-10 12 17 39

@Gabriel-p Gabriel-p added the bug label Aug 10, 2017
@Gabriel-p Gabriel-p added this to the v0.3.0 milestone Aug 10, 2017
@Gabriel-p Gabriel-p self-assigned this Aug 10, 2017
Gabriel-p added a commit that referenced this issue Aug 10, 2017
@Gabriel-p Gabriel-p modified the milestones: v0.3.0, v0.2.1 Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant