Skip to content

Commit

Permalink
Upgrade Puppeteer to version 1.1.1
Browse files Browse the repository at this point in the history
  • Loading branch information
astefanutti committed Feb 28, 2018
1 parent 405a07f commit 1ee6449
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 28 deletions.
8 changes: 4 additions & 4 deletions decktape.js
Original file line number Diff line number Diff line change
Expand Up @@ -198,14 +198,14 @@ process.on('unhandledRejection', error => {
page
.on('console', (...args) => console.log(chalk`{gray ${args}}`))
.on('pageerror', error => console.log(chalk`\n{red Page error: ${error.message}}`))
.on('requestfailed', request => console.log(chalk`\n{keyword('orange') Unable to load resource from URL: ${request.url}}`));
.on('requestfailed', request => console.log(chalk`\n{keyword('orange') Unable to load resource from URL: ${request.url()}}`));

console.log('Loading page', options.url, '...');
const load = page.waitForNavigation({ waitUntil: 'load', timeout: 20000 });
page.goto(options.url, { waitUntil: 'networkidle', timeout: 60000 })
page.goto(options.url, { waitUntil: 'networkidle0', timeout: 60000 })
// wait until the load event is dispatched
.then(response => load.catch(error => response.status !== 200 ? Promise.reject(error) : response))
.then(response => console.log('Loading page finished with status:', response.status))
.then(response => load.catch(error => response.status() !== 200 ? Promise.reject(error) : response))
.then(response => console.log('Loading page finished with status:', response.status()))
.then(delay(options.loadPause))
.then(_ => createPlugin(page))
.then(plugin => configurePlugin(plugin)
Expand Down
46 changes: 23 additions & 23 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"chalk": "^2.1.0",
"fonteditor-core": "^1.0.2",
"hummus": "^1.0.83",
"puppeteer": "^0.12.0",
"puppeteer": "^1.1.1",
"urijs": "^1.18.12"
},
"engines": {
Expand Down

0 comments on commit 1ee6449

Please sign in to comment.