Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cells with "Speak custom text" must speak custom text when accumulated phrase is readed. #182

Closed
arasaac-dga opened this issue Nov 10, 2022 · 14 comments
Labels
good first issue Good for newcomers

Comments

@arasaac-dga
Copy link
Collaborator

Cells with custom text should speak the custom text when reading the accumulated sentence instead of the label text (showing the label text under the symbols as now).

@mjtc1985
Copy link

Hello, I opened a pull request #265 to try to solve this issue.

klues added a commit that referenced this issue May 3, 2023
…custom-text

Use custom text value for "Speak custom text" to speech instead ob label value
@klues
Copy link
Contributor

klues commented May 3, 2023

Great, thanks! 👍
I think the first issue that is fixed by an external contributor 🎉

I've merged the PR and released it to https://grid.asterics.eu/latest/
@arasaac-dga please test there and give your feedback.

Priority of speaking (in mode "speak separately") is now:

  1. Recorded audio, if available
  2. Text from "speak custom text", if available
  3. Fixed grammar by your API, if available
  4. Normal label of the element

In mode "speak continiously" recorded audio isn't used.

@arasaac-dga
Copy link
Collaborator Author

We have tested it and it works great except when "automatic grammar correction" is activated in Spanish. In this case as you can see in the attached video there is a problem with custom text that is distributed in the consecutive cells (one word per cell) deleting the correct text of each cell. If you continue pressing the Play button the problem is increased.

https://app.box.com/s/0zqe2o3t2d0fpk4kuvojeauudffgftn1

@klues
Copy link
Contributor

klues commented May 4, 2023

I've released this to main version with https://github.com/asterics/AsTeRICS-Grid/releases/tag/release-2023-05-04-16.18%2F%2B0200 since we wanted to release the new application language romanian.

Since the issue is only related to the automatic grammar correction (which isn't released yet), we'll have to fix it before releasing #242 to main version. It's still for testing in latest version

@klues
Copy link
Contributor

klues commented May 31, 2023

I think it would be most consistent for cells with custom text that the custom text is also shown within the collect element like this:
grafik

@arasaac-dga what do you think?

klues added a commit that referenced this issue May 31, 2023
@klues
Copy link
Contributor

klues commented May 31, 2023

Please test the current version at https://grid.asterics.eu/latest/

The issue with distributing words across cells should be fixed, however I've tested the example from your video and your API returns: YO NECESITO DESCANSO MUCHO PARA ESTAR MUY FUERTE which I think (or at least ChatGPT thinks) is not correct:

grafik

And "TÚ QUIERO" again results in "TÚ QUIERO" - I think this was already correct at some time and resulted in "TÚ QUIERES"?!

@arasaac-dga
Copy link
Collaborator Author

We have tested and works fine and the issue shown in the video attached at the beginning is solved with the same example. Only we have detected with the same example that when you play several times, for example, in the third one change "NECESITO DESCANSO" that is correct by "NECESITO DESCANSAMOS" (that is not correct) and in fourth ("NECESITO DESCANSAR") (that is correct too).

2023-05-31.11-30-46.mp4

As we see it is a problem in our API (we have replied to it in our API). So, launch it to main and we check and solve all the errors that appear on our part with the API.

@klues
Copy link
Contributor

klues commented May 31, 2023

released with https://github.com/asterics/AsTeRICS-Grid/releases/tag/release-2023-05-31-13.40%2F%2B0200

@klues klues closed this as completed May 31, 2023
@arasaac-dga
Copy link
Collaborator Author

Thanks. We have solved the problem. It was a problem in service that control the API on server that needed a reset ;-)

@klues
Copy link
Contributor

klues commented May 31, 2023

"NECESITO DESCANSO" that is correct

ok, so ChatGPT doesn't know spanish very well ;)

However I still get "YO QUIERO".

@klues
Copy link
Contributor

klues commented May 31, 2023

sorry, I meant "TU QUIERO".

@arasaac-dga
Copy link
Collaborator Author

No "Tu quiero" is not correct. It would be "Tú quieres". ChatGPT know very good spanish and he tries to offer the most correct phrase. So our phrase is correct although always there are other possibilities more used, for example. Anyway, we are going to monitorize everything and receive feedback of users that sure will help to improve our API. Thanks

@klues
Copy link
Contributor

klues commented May 31, 2023

Yes, I know, but I receive "tu quiero" from your API:

image

@arasaac-dga
Copy link
Collaborator Author

Yes. This is because "QUIERO" is conjugated and is third person (not first person as YO. We will add a exception in our API to handle this with users that have QUIERO instead of QUERER (the inifinitive) and we will send you by email a new backup in Spanish of ARASAAC Global Communicator in which he have changed QUIERO by QUERER. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants