-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting running kernel mode unit test in kernel threads #748
Conversation
This is an important missing feature of the ktest mechanism. Very excited to see this PR. I skimmed over the changes. Looks fine to me. @junyang-zh As the author of ktest, your opinion would be highly appreciated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is just the first step to run ktests in parallel. If you are uninterested in implementing the following features, I am OK to take and I am OK with the scope of this PR.
Considering that we currently do not support multi-threading and cannot conduct complete testing even after implementation, I think the current PR should be enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for contribution!
This pull request enhances the execution of ktests within a task-based context by performing the following steps:
run_ktests
function into the task context.Task
within this pull request for comprehensive functionality.The development of capabilities to facilitate the concurrent execution of multiple ktest tasks is still an ongoing effort. Despite Asterinas currently only supporting a single core, the parallelization of unit tests is a more logical approach, promising improved efficiency and performance. This feature will involve a lot of code in
libs/ktest
and requires further discussion.