Docker module

[BrianHicks]

Docker module should:

• get image (version or "latest")

I'm not sure if it should ensure the container is running or not. Thoughts?

[ryane]

would it make sense to split into docker image and container resources? the container resource could be responsible for ensuring the container is running

[BrianHicks]

Let’s go with docker.image and docker.container.

On 16 Aug 2016, at 16:58, Ryan Eschinger wrote:

would it make sense to split into docker image and container
resources? the container resource could be responsible for ensuring
the container is running

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#159 (comment)

[rebeccaskinner]

Just contributing random ideas but maybe they could look something like...

docker.image 'rabbitmq' {
    image = "rabbitmq"
    tag = "ctl"
}

docker.container "rabbit instance" {
    image = "rabbitmq"
    tag = "ctl"
    name = "dockerinstance"
    env = [...]
    ...
    depends = ["docker.image.rabbitmq"]
}

[BrianHicks]

that's more or less exactly what I was thinking, actually.

Probably start with docker.image if you take this ticket, @ryane. Much simpler from what I remember of that API. When you get that in we can talk about how it looks before you do the other one. Smaller PRs FTW.

[BrianHicks]

Exactly. But the image module is the simpler of the two to implement first.

On Aug 16, 2016, at 4:58 PM, Ryan Eschinger notifications@github.com wrote:

would it make sense to split into docker image and container resources? the container resource could be responsible for ensuring the container is running

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[stevendborrelli]

Closing via #178