named groups #392
Merged
named groups #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will |
ryane
force-pushed
the
feature/named-groups
branch
from
8ab0c31
to
9d8533a
Compare
|
Yeah, I suppose it would (doesn't look like we have any fields call just "group" right now though). Should we rename it back to "lock"? something else? |
ryane
force-pushed
the
feature/named-groups
branch
from
9d8533a
to
1abd779
Compare
|
Two nodes that share a group and also have an explicit dependency seems to cause a deadlock. Example: task.query "a" {
query = "echo a"
group = "query"
depends = ["task.query.b"]
}
task.query "b" {
query = "echo b"
group = "query"
} |
ryane
force-pushed
the
feature/named-groups
branch
from
1abd779
to
1fccc09
Compare
rebeccaskinner
suggested changes
Oct 21, 2016
| return len(b.g.Dependencies(b.nodes[i].ID)) > len(b.g.Dependencies(b.nodes[j].ID)) | ||
| } | ||
|
|
||
| func groupDeps(ctx context.Context, g *graph.Graph, group string) (*graph.Graph, error) { |
There was a problem hiding this comment.
Is there any way that we can reasonably break this up to factor out smaller helper functions? Like maybe pulling some of the individual for loops out into helper functions?
There was a problem hiding this comment.
I broke out each stage into separate functions.
rebeccaskinner
approved these changes
Oct 21, 2016
|
LGTM! |
|
thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #249
replaces #379