Feature/requirements #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…checking parsing.
- module arguments are now contained in a dedicated field 'params'
ex module "x" "y"{
params = {
arg1 = "1"}}
- explicit dependencies now work with a few caveats
*an empty array of dependencies ([]) works but not an array of empty strings ([""])*
*dependent calls to a module task work fine*
Merge branch 'master' of https://github.com/asteris-llc/converge into feature/requirements
…module as a depedencies. TODO : when we parallelize this, will this need to change?
… feature/requirements
… feature/requirements
| @@ -67,8 +68,13 @@ func (g *Graph) load() error { | |||
| ids = append(ids, childID) | |||
| } | |||
| } | |||
| for _, id := range ids { | |||
| //fmt.Printf("ID: %q, Res: %+v\n\n", id.ID, id.Resource) | |||
| @@ -0,0 +1,13 @@ | |||
| param "message" { default = "Hello, World!" } | |||
There was a problem hiding this comment.
this file needs a better name. How about basicDependencies.hcl?
…rray" This reverts commit 9694b4b.
| @@ -50,7 +50,8 @@ type ident struct { | |||
| } | |||
|
|
|||
| func (g *Graph) load() error { | |||
| ids := []ident{{g.root.Name(), g.root}} | |||
| rootID := g.root.Name() | |||
1. Checks that dependencies of a resource are lower in the tree than the resource 2. Checks that terraform's tree goes through nodes depth first
The `TransitiveReduction` function was removing dependency links because their goal is to make the graph equally as walkable but not necessarily as connected. However, we still need the `b -> d` edge which was being removed.
BrianHicks
force-pushed
the
feature/requirements
branch
from
f5fbeee
to
b0d3e1c
Compare
|
That said, thanks for your hard work on this, it's great. 👍 |
BrianHicks
pushed a commit
that referenced
this pull request
Dec 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fulfills the Requirements issue.
Resource blocks should have requirements.
These requirements:
are limited to the names in the current module. You can require a module call to be completed, though.
If no requirements are specified, it is assumed that the task before the current task is the only requirement
If an empty list of tasks is specified, it is accepted that the task has no dependencies aside from being executed as part of the module
Caveats
Extended the Resource Interface Depends() []string -Extended the Task Interface with AddDep(string) and RemoveDep(string)
Implement the new/changed interface for relevant nodes (probably just ShellTask, Template, and ModuleCall)
Made sure walking the graph works correctly and in the order the new requirements specify.