Skip to content

Commit

Permalink
Merge "SRTP: Lower SDES key lifetime minimum to 2^20"
Browse files Browse the repository at this point in the history
  • Loading branch information
gtjoseph authored and Gerrit Code Review committed Jul 18, 2018
2 parents d9596b5 + 993ba84 commit 5f01f73
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions res/res_srtp.c
Original file line number Diff line number Diff line change
Expand Up @@ -980,8 +980,8 @@ static int res_sdp_crypto_parse_offer(struct ast_rtp_instance *rtp, struct ast_s
sdes_lifetime = n_lifetime;
}

/* Accept anything above 10 hours. Less than 10; reject. */
if (sdes_lifetime < 1800000) {
/* Accept anything above ~5.8 hours. Less than ~5.8; reject. */
if (sdes_lifetime < 1048576) {
ast_log(LOG_NOTICE, "Rejecting crypto attribute '%s': lifetime '%f' too short\n", attr, sdes_lifetime);
continue;
}
Expand Down

0 comments on commit 5f01f73

Please sign in to comment.