Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: unlock channel after moh state access #133

Closed
1 task done
mbradeen opened this issue May 31, 2023 · 0 comments · Fixed by #134
Closed
1 task done

[bug]: unlock channel after moh state access #133

mbradeen opened this issue May 31, 2023 · 0 comments · Fixed by #134
Assignees
@mbradeen
Labels
bug support-level-core Functionality with core support level

Comments

@mbradeen
Copy link
Contributor

Severity

Trivial

Versions

18, 20, master

Components/Modules

res_musiconhold

Operating Environment

ubuntu

Frequency of Occurrence

None

Issue Description

CommUnity UCaaS submission - moh_files_generator releases channel lock while still accessing channel moh state.

Relevant log output

No response

Asterisk Issue Guidelines

  • Yes, I have read the Asterisk Issue Guidelines
@mbradeen mbradeen added bug triage support-level-core Functionality with core support level and removed triage labels May 31, 2023
@mbradeen mbradeen mentioned this issue May 31, 2023
Merged
mbradeen added a commit to mbradeen/asterisk that referenced this issue May 31, 2023
@mbradeen
res_musiconhold: avoid moh state access on unlocked chan
2304d2d 
Move channel unlock to after moh state access to avoid
potential unlocked access to state.

Resolves: asterisk#133
mbradeen added a commit to mbradeen/asterisk that referenced this issue Jun 2, 2023
@mbradeen
res_musiconhold: avoid moh state access on unlocked chan
5a43524 
Move channel unlock to after moh state access to avoid
potential unlocked access to state.

Resolves: asterisk#133
mbradeen added a commit to mbradeen/asterisk that referenced this issue Jun 5, 2023
@mbradeen
res_musiconhold: avoid moh state access on unlocked chan
e770b0d 
Move channel unlock to after moh state access to avoid
potential unlocked access to state.

Resolves: asterisk#133
asterisk-org-access-app bot pushed a commit that referenced this issue Jun 29, 2023
@mbradeen
res_musiconhold: avoid moh state access on unlocked chan
9c88991 
Move channel unlock to after moh state access to avoid
potential unlocked access to state.

Resolves: #133
asterisk-org-access-app bot pushed a commit that referenced this issue Jun 29, 2023
@mbradeen
res_musiconhold: avoid moh state access on unlocked chan
98d8e9b 
Move channel unlock to after moh state access to avoid
potential unlocked access to state.

Resolves: #133
asterisk-org-access-app bot pushed a commit that referenced this issue Jun 29, 2023
@mbradeen
res_musiconhold: avoid moh state access on unlocked chan
f5f0924 
Move channel unlock to after moh state access to avoid
potential unlocked access to state.

Resolves: #133
asterisk-org-access-app bot pushed a commit that referenced this issue Jun 29, 2023
@mbradeen @asterisk-org-access-app
res_musiconhold: avoid moh state access on unlocked chan
e84fe59 
Move channel unlock to after moh state access to avoid
potential unlocked access to state.

Resolves: #133
asterisk-org-access-app bot pushed a commit that referenced this issue Jun 30, 2023
@mbradeen @asteriskteam
res_musiconhold: avoid moh state access on unlocked chan
5656c6e 
Move channel unlock to after moh state access to avoid
potential unlocked access to state.

Resolves: #133
(cherry picked from commit 98d8e9b)
asterisk-org-access-app bot pushed a commit that referenced this issue Jun 30, 2023
@mbradeen @asteriskteam
res_musiconhold: avoid moh state access on unlocked chan
8e73e3b 
Move channel unlock to after moh state access to avoid
potential unlocked access to state.

Resolves: #133
(cherry picked from commit 98d8e9b)
asterisk-org-access-app bot pushed a commit that referenced this issue Jun 30, 2023
@mbradeen @asteriskteam
res_musiconhold: avoid moh state access on unlocked chan
3852e89 
Move channel unlock to after moh state access to avoid
potential unlocked access to state.

Resolves: #133
(cherry picked from commit 98d8e9b)
asterisk-org-access-app bot pushed a commit that referenced this issue Jun 30, 2023
@mbradeen @asteriskteam
res_musiconhold: avoid moh state access on unlocked chan
16af21e 
Move channel unlock to after moh state access to avoid
potential unlocked access to state.

Resolves: #133
(cherry picked from commit 98d8e9b)
asterisk-org-access-app bot pushed a commit that referenced this issue Jun 30, 2023
@mbradeen @asteriskteam
res_musiconhold: avoid moh state access on unlocked chan
1fdb07e 
Move channel unlock to after moh state access to avoid
potential unlocked access to state.

Resolves: #133
(cherry picked from commit 98d8e9b)
asterisk-org-access-app bot pushed a commit that referenced this issue Jun 30, 2023
@mbradeen @asteriskteam
res_musiconhold: avoid moh state access on unlocked chan
0bcb42a 
Move channel unlock to after moh state access to avoid
potential unlocked access to state.

Resolves: #133
(cherry picked from commit 9c88991)
gtjoseph pushed a commit that referenced this issue Jul 7, 2023
@mbradeen @gtjoseph
res_musiconhold: avoid moh state access on unlocked chan
9a4a097 
Move channel unlock to after moh state access to avoid
potential unlocked access to state.

Resolves: #133
asterisk-org-access-app bot pushed a commit that referenced this issue Jul 10, 2023
@mbradeen @asteriskteam
res_musiconhold: avoid moh state access on unlocked chan
8963e15 
Move channel unlock to after moh state access to avoid
potential unlocked access to state.

Resolves: #133
(cherry picked from commit 98d8e9b)
asterisk-org-access-app bot pushed a commit that referenced this issue Jul 10, 2023
@mbradeen @asteriskteam
res_musiconhold: avoid moh state access on unlocked chan
9dbd80a 
Move channel unlock to after moh state access to avoid
potential unlocked access to state.

Resolves: #133
(cherry picked from commit 9c88991)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbradeen mbradeen

Labels
bug support-level-core Functionality with core support level
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

res_musiconhold: avoid moh state access on unlocked chan mbradeen/asterisk
1 participant
@mbradeen