[bug]: recent change refers to ALLPERMS which is not always defined

[micmac1]

Severity

Minor

Versions

20.2.0

Components/Modules

res_crypto

Operating Environment

OpenWrt musl libc

Frequency of Occurrence

Constant

Issue Description

Commit d0bea5a included sys/stat.h and refers to ALLPERMS, which is not POSIX and as such may not be available everywhere.

Would be nice to get this fixed, thanks.

Ping @pprindeville

Relevant log output

res_crypto.c: In function 'try_load_key':
res_crypto.c:222:28: error: 'ALLPERMS' undeclared (first use in this function)
  222 |             ((st.st_mode & ALLPERMS) & ~(S_IRUSR | S_IWUSR)) != 0) {
      |                            ^~~~~~~~

Asterisk Issue Guidelines

• Yes, I have read the Asterisk Issue Guidelines

[pprindeville]

Sorry for not having a chance to get to this before: my development testbed had vapors and I spent the last couple of days migrating VMs to a new platform.

Personally, I'd have preferred a low touch fix instead, and since ALLPERMS is a familiar paradigm for most Linux programmers, I'd have left it. The solution I would have gone with is:

#if !defined(ALLPERMS)
#define ALLPERMS ...
#endif

instead.

[seanbright]

Sorry for not having a chance to get to this before: my development testbed had vapors and I spent the last couple of days migrating VMs to a new platform.

Personally, I'd have preferred a low touch fix instead, and since ALLPERMS is a familiar paradigm for most Linux programmers, I'd have left it. The solution I would have gone with is:

#if !defined(ALLPERMS)
#define ALLPERMS ...
#141

instead.

Feel free to open another PR with your preferred fix.

[pprindeville]

Feel free to open another PR with your preferred fix. Make sure to use #endif instead of #141 though.

Overzealous completion... not sure why it does that inside of triple-backticks...