Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: test_stasis_endpoints.c: Unit test channel_messages is unstable #158

Closed
1 task done
gtjoseph opened this issue Jun 9, 2023 · 0 comments · Fixed by #159
Closed
1 task done

[bug]: test_stasis_endpoints.c: Unit test channel_messages is unstable #158

gtjoseph opened this issue Jun 9, 2023 · 0 comments · Fixed by #159
Labels
bug support-level-core Functionality with core support level

Comments

@gtjoseph
Copy link
Member

gtjoseph commented Jun 9, 2023

Severity

Major

Versions

18,20,master

Components/Modules

test_stasis_endpoints

Operating Environment

Rocky 8 CI environment

Frequency of Occurrence

Occasional

Issue Description

The channel_messages test occasionally fails. It looks like it's expecting stasis to deliver messages in a specific order which isn't guaranteed.

Relevant log output

[test_stasis_endpoints.c:channel_messages:264]: Condition failed: ast_channel_snapshot_type() == type

Asterisk Issue Guidelines

  • Yes, I have read the Asterisk Issue Guidelines
@gtjoseph gtjoseph added bug triage support-level-core Functionality with core support level and removed triage labels Jun 9, 2023
@gtjoseph gtjoseph mentioned this issue Jun 9, 2023
Merged
asterisk-org-access-app bot pushed a commit that referenced this issue Jun 9, 2023
@gtjoseph
test_stasis_endpoints.c: Make channel_messages more stable
833543d 
The channel_messages test was assuming that stasis would return
messages in a specific order.  This is an incorrect assumption as
message ordering was never guaranteed.  This was causing the test
to fail occasionally.  We now test all the messages for the
required message types instead of testing one by one.

Resolves: #158
asterisk-org-access-app bot pushed a commit that referenced this issue Jun 9, 2023
@gtjoseph
test_stasis_endpoints.c: Make channel_messages more stable
83781c2 
The channel_messages test was assuming that stasis would return
messages in a specific order.  This is an incorrect assumption as
message ordering was never guaranteed.  This was causing the test
to fail occasionally.  We now test all the messages for the
required message types instead of testing one by one.

Resolves: #158
asterisk-org-access-app bot pushed a commit that referenced this issue Jun 9, 2023
@gtjoseph
test_stasis_endpoints.c: Make channel_messages more stable
653aee2 
The channel_messages test was assuming that stasis would return
messages in a specific order.  This is an incorrect assumption as
message ordering was never guaranteed.  This was causing the test
to fail occasionally.  We now test all the messages for the
required message types instead of testing one by one.

Resolves: #158
asterisk-org-access-app bot pushed a commit that referenced this issue Jun 9, 2023
@gtjoseph @asterisk-org-access-app
test_stasis_endpoints.c: Make channel_messages more stable
297e2cd 
The channel_messages test was assuming that stasis would return
messages in a specific order.  This is an incorrect assumption as
message ordering was never guaranteed.  This was causing the test
to fail occasionally.  We now test all the messages for the
required message types instead of testing one by one.

Resolves: #158
asterisk-org-access-app bot pushed a commit that referenced this issue Jun 30, 2023
@gtjoseph @asteriskteam
test_stasis_endpoints.c: Make channel_messages more stable
dc2ab2c 
The channel_messages test was assuming that stasis would return
messages in a specific order.  This is an incorrect assumption as
message ordering was never guaranteed.  This was causing the test
to fail occasionally.  We now test all the messages for the
required message types instead of testing one by one.

Resolves: #158
(cherry picked from commit 833543d)
asterisk-org-access-app bot pushed a commit that referenced this issue Jun 30, 2023
@gtjoseph @asteriskteam
test_stasis_endpoints.c: Make channel_messages more stable
dfb3886 
The channel_messages test was assuming that stasis would return
messages in a specific order.  This is an incorrect assumption as
message ordering was never guaranteed.  This was causing the test
to fail occasionally.  We now test all the messages for the
required message types instead of testing one by one.

Resolves: #158
(cherry picked from commit 833543d)
asterisk-org-access-app bot pushed a commit that referenced this issue Jun 30, 2023
@gtjoseph @asteriskteam
test_stasis_endpoints.c: Make channel_messages more stable
1e3beb7 
The channel_messages test was assuming that stasis would return
messages in a specific order.  This is an incorrect assumption as
message ordering was never guaranteed.  This was causing the test
to fail occasionally.  We now test all the messages for the
required message types instead of testing one by one.

Resolves: #158
(cherry picked from commit 833543d)
asterisk-org-access-app bot pushed a commit that referenced this issue Jun 30, 2023
@gtjoseph @asteriskteam
test_stasis_endpoints.c: Make channel_messages more stable
c79c694 
The channel_messages test was assuming that stasis would return
messages in a specific order.  This is an incorrect assumption as
message ordering was never guaranteed.  This was causing the test
to fail occasionally.  We now test all the messages for the
required message types instead of testing one by one.

Resolves: #158
(cherry picked from commit 833543d)
asterisk-org-access-app bot pushed a commit that referenced this issue Jun 30, 2023
@gtjoseph @asteriskteam
test_stasis_endpoints.c: Make channel_messages more stable
db00c4c 
The channel_messages test was assuming that stasis would return
messages in a specific order.  This is an incorrect assumption as
message ordering was never guaranteed.  This was causing the test
to fail occasionally.  We now test all the messages for the
required message types instead of testing one by one.

Resolves: #158
(cherry picked from commit 833543d)
asterisk-org-access-app bot pushed a commit that referenced this issue Jun 30, 2023
@gtjoseph @asteriskteam
test_stasis_endpoints.c: Make channel_messages more stable
c743748 
The channel_messages test was assuming that stasis would return
messages in a specific order.  This is an incorrect assumption as
message ordering was never guaranteed.  This was causing the test
to fail occasionally.  We now test all the messages for the
required message types instead of testing one by one.

Resolves: #158
(cherry picked from commit 83781c2)
gtjoseph added a commit that referenced this issue Jul 6, 2023
@gtjoseph
test_stasis_endpoints.c: Make channel_messages more stable
a5c4f3e 
The channel_messages test was assuming that stasis would return
messages in a specific order.  This is an incorrect assumption as
message ordering was never guaranteed.  This was causing the test
to fail occasionally.  We now test all the messages for the
required message types instead of testing one by one.

Resolves: #158
gtjoseph added a commit that referenced this issue Jul 7, 2023
@gtjoseph
test_stasis_endpoints.c: Make channel_messages more stable
53d3f88 
The channel_messages test was assuming that stasis would return
messages in a specific order.  This is an incorrect assumption as
message ordering was never guaranteed.  This was causing the test
to fail occasionally.  We now test all the messages for the
required message types instead of testing one by one.

Resolves: #158
asterisk-org-access-app bot pushed a commit that referenced this issue Jul 10, 2023
@gtjoseph @asteriskteam
test_stasis_endpoints.c: Make channel_messages more stable
b59f9cb 
The channel_messages test was assuming that stasis would return
messages in a specific order.  This is an incorrect assumption as
message ordering was never guaranteed.  This was causing the test
to fail occasionally.  We now test all the messages for the
required message types instead of testing one by one.

Resolves: #158
(cherry picked from commit 833543d)
asterisk-org-access-app bot pushed a commit that referenced this issue Jul 10, 2023
@gtjoseph @asteriskteam
test_stasis_endpoints.c: Make channel_messages more stable
b7775ae 
The channel_messages test was assuming that stasis would return
messages in a specific order.  This is an incorrect assumption as
message ordering was never guaranteed.  This was causing the test
to fail occasionally.  We now test all the messages for the
required message types instead of testing one by one.

Resolves: #158
(cherry picked from commit 83781c2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug support-level-core Functionality with core support level
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test_stasis_endpoints.c: Make channel_messages more stable
1 participant
@gtjoseph