[bug]: third-party/apply-patches doesn't sort the patch file list before applying #193
Closed
1 task done
Labels
Comments
gtjoseph
added
bug
triage
support-level-core
gtjoseph
added a commit
that referenced
this issue
Jul 6, 2023
The apply_patches script wasn't sorting the list of patches in the "patches" directory before applying them. This left the list in an indeterminate order. In most cases, the list is actually sorted but rarely, they can be out of order and cause dependent patches to fail to apply. We now sort the list but the "sort" program wasn't in the configure scripts so we needed to add that and regenerate the scripts as well. Resolves: #193
gtjoseph
added a commit
that referenced
this issue
Jul 6, 2023
The apply_patches script wasn't sorting the list of patches in the "patches" directory before applying them. This left the list in an indeterminate order. In most cases, the list is actually sorted but rarely, they can be out of order and cause dependent patches to fail to apply. We now sort the list but the "sort" program wasn't in the configure scripts so we needed to add that and regenerate the scripts as well. Resolves: #193
gtjoseph
added a commit
that referenced
this issue
Jul 6, 2023
The apply_patches script wasn't sorting the list of patches in the "patches" directory before applying them. This left the list in an indeterminate order. In most cases, the list is actually sorted but rarely, they can be out of order and cause dependent patches to fail to apply. We now sort the list but the "sort" program wasn't in the configure scripts so we needed to add that and regenerate the scripts as well. Resolves: #193
gtjoseph
added a commit
that referenced
this issue
Jul 6, 2023
The apply_patches script wasn't sorting the list of patches in the "patches" directory before applying them. This left the list in an indeterminate order. In most cases, the list is actually sorted but rarely, they can be out of order and cause dependent patches to fail to apply. We now sort the list but the "sort" program wasn't in the configure scripts so we needed to add that and regenerate the scripts as well. Resolves: #193
gtjoseph
added a commit
that referenced
this issue
Jul 6, 2023
The apply_patches script wasn't sorting the list of patches in the "patches" directory before applying them. This left the list in an indeterminate order. In most cases, the list is actually sorted but rarely, they can be out of order and cause dependent patches to fail to apply. We now sort the list but the "sort" program wasn't in the configure scripts so we needed to add that and regenerate the scripts as well. Resolves: #193
gtjoseph
added a commit
that referenced
this issue
Jul 7, 2023
The apply_patches script wasn't sorting the list of patches in the "patches" directory before applying them. This left the list in an indeterminate order. In most cases, the list is actually sorted but rarely, they can be out of order and cause dependent patches to fail to apply. We now sort the list but the "sort" program wasn't in the configure scripts so we needed to add that and regenerate the scripts as well. Resolves: #193
gtjoseph
added a commit
that referenced
this issue
Jul 7, 2023
The apply_patches script wasn't sorting the list of patches in the "patches" directory before applying them. This left the list in an indeterminate order. In most cases, the list is actually sorted but rarely, they can be out of order and cause dependent patches to fail to apply. We now sort the list but the "sort" program wasn't in the configure scripts so we needed to add that and regenerate the scripts as well. Resolves: #193
gtjoseph
added a commit
that referenced
this issue
Jul 7, 2023
The apply_patches script wasn't sorting the list of patches in the "patches" directory before applying them. This left the list in an indeterminate order. In most cases, the list is actually sorted but rarely, they can be out of order and cause dependent patches to fail to apply. We now sort the list but the "sort" program wasn't in the configure scripts so we needed to add that and regenerate the scripts as well. Resolves: #193
gtjoseph
added a commit
that referenced
this issue
Jul 7, 2023
The apply_patches script wasn't sorting the list of patches in the "patches" directory before applying them. This left the list in an indeterminate order. In most cases, the list is actually sorted but rarely, they can be out of order and cause dependent patches to fail to apply. We now sort the list but the "sort" program wasn't in the configure scripts so we needed to add that and regenerate the scripts as well. Resolves: #193
gtjoseph
added a commit
that referenced
this issue
Jul 7, 2023
The apply_patches script wasn't sorting the list of patches in the "patches" directory before applying them. This left the list in an indeterminate order. In most cases, the list is actually sorted but rarely, they can be out of order and cause dependent patches to fail to apply. We now sort the list but the "sort" program wasn't in the configure scripts so we needed to add that and regenerate the scripts as well. Resolves: #193
gtjoseph
added a commit
that referenced
this issue
Jul 7, 2023
The apply_patches script wasn't sorting the list of patches in the "patches" directory before applying them. This left the list in an indeterminate order. In most cases, the list is actually sorted but rarely, they can be out of order and cause dependent patches to fail to apply. We now sort the list but the "sort" program wasn't in the configure scripts so we needed to add that and regenerate the scripts as well. Resolves: #193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Severity
Minor
Versions
16,18,19,20,master
Components/Modules
build_system
Operating Environment
Rocky Linux 8
Frequency of Occurrence
Frequent
Issue Description
The apply_patches script doesn't sort the list of patches in the "patches" directory before applying them. This leaves the list in an indeterminate order. In most cases, the list is actually sorted but rarely, they can be out of order and cause dependent patches to fail to apply.
Relevant log output
[pjproject] Unpacking /tmp/pjproject-2.12.1.tar.bz2 Applying patch 0300-Merge-pull-request-from-GHSA-9pfh-r8x4-w26w.patch Applying patch 0000-configure-ssl-library-path.patch Applying patch 0200-potential-buffer-overflow-in-pjlib-scanner-and-pjmedia.patch Applying patch 0000-remove-third-party.patch Applying patch 0303-Don-t-call-SSL_shutdown-when-receiving-SSL_ERROR_SYS.patch 1 out of 1 hunk FAILED -- saving rejects to file pjlib/src/pj/ssl_sock_ossl.c.rej In this case, the 0303 patch was dependent on an 0302 patch that hadn't been applied yet.Asterisk Issue Guidelines
The text was updated successfully, but these errors were encountered: