Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: app_dial: Infinite loop if called channel hangs up while receiving digits #281

Closed
1 task done
InterLinked1 opened this issue Aug 28, 2023 · 0 comments · Fixed by #282
Closed
1 task done
Assignees
Labels
bug support-level-core Functionality with core support level

Comments

@InterLinked1
Copy link
Contributor

Severity

Major

Versions

All

Components/Modules

app_dial

Operating Environment

N/A

Frequency of Occurrence

Constant

Issue Description

Imported from JIRA: https://issues-archive.asterisk.org/ASTERISK-29428

This fixes an issue in app_dial whereby the channel will enter an infinite loop that does not end until the caller manually hangs up, if the called channel hangs up while the calling channel is sending digits to it.

Relevant log output

No response

Asterisk Issue Guidelines

  • Yes, I have read the Asterisk Issue Guidelines
InterLinked1 added a commit to InterLinked1/asterisk that referenced this issue Aug 28, 2023
If the called party hangs up while digits are being
sent, -1 is returned to indicate so, but app_dial
was not checking the return value, resulting in
the hangup being lost and looping forever until
the caller manually hangs up the channel. We now
abort if digit sending fails.

ASTERISK-29428 #close

Resolves: asterisk#281
@jcolp jcolp added support-level-core Functionality with core support level and removed triage labels Aug 28, 2023
InterLinked1 added a commit to InterLinked1/asterisk that referenced this issue Aug 30, 2023
If the called party hangs up while digits are being
sent, -1 is returned to indicate so, but app_dial
was not checking the return value, resulting in
the hangup being lost and looping forever until
the caller manually hangs up the channel. We now
abort if digit sending fails.

ASTERISK-29428 #close

Resolves: asterisk#281
asterisk-org-access-app bot pushed a commit that referenced this issue Aug 31, 2023
If the called party hangs up while digits are being
sent, -1 is returned to indicate so, but app_dial
was not checking the return value, resulting in
the hangup being lost and looping forever until
the caller manually hangs up the channel. We now
abort if digit sending fails.

ASTERISK-29428 #close

Resolves: #281
asterisk-org-access-app bot pushed a commit that referenced this issue Aug 31, 2023
If the called party hangs up while digits are being
sent, -1 is returned to indicate so, but app_dial
was not checking the return value, resulting in
the hangup being lost and looping forever until
the caller manually hangs up the channel. We now
abort if digit sending fails.

ASTERISK-29428 #close

Resolves: #281
asterisk-org-access-app bot pushed a commit that referenced this issue Aug 31, 2023
If the called party hangs up while digits are being
sent, -1 is returned to indicate so, but app_dial
was not checking the return value, resulting in
the hangup being lost and looping forever until
the caller manually hangs up the channel. We now
abort if digit sending fails.

ASTERISK-29428 #close

Resolves: #281
asterisk-org-access-app bot pushed a commit that referenced this issue Aug 31, 2023
If the called party hangs up while digits are being
sent, -1 is returned to indicate so, but app_dial
was not checking the return value, resulting in
the hangup being lost and looping forever until
the caller manually hangs up the channel. We now
abort if digit sending fails.

ASTERISK-29428 #close

Resolves: #281
asterisk-org-access-app bot pushed a commit that referenced this issue Sep 6, 2023
If the called party hangs up while digits are being
sent, -1 is returned to indicate so, but app_dial
was not checking the return value, resulting in
the hangup being lost and looping forever until
the caller manually hangs up the channel. We now
abort if digit sending fails.

ASTERISK-29428 #close

Resolves: #281
(cherry picked from commit 1ada3c0)
asterisk-org-access-app bot pushed a commit that referenced this issue Sep 6, 2023
If the called party hangs up while digits are being
sent, -1 is returned to indicate so, but app_dial
was not checking the return value, resulting in
the hangup being lost and looping forever until
the caller manually hangs up the channel. We now
abort if digit sending fails.

ASTERISK-29428 #close

Resolves: #281
(cherry picked from commit 4542ffe)
asterisk-org-access-app bot pushed a commit that referenced this issue Sep 6, 2023
If the called party hangs up while digits are being
sent, -1 is returned to indicate so, but app_dial
was not checking the return value, resulting in
the hangup being lost and looping forever until
the caller manually hangs up the channel. We now
abort if digit sending fails.

ASTERISK-29428 #close

Resolves: #281
(cherry picked from commit c032d38)
asterisk-org-access-app bot pushed a commit that referenced this issue Sep 6, 2023
If the called party hangs up while digits are being
sent, -1 is returned to indicate so, but app_dial
was not checking the return value, resulting in
the hangup being lost and looping forever until
the caller manually hangs up the channel. We now
abort if digit sending fails.

ASTERISK-29428 #close

Resolves: #281
(cherry picked from commit c032d38)
asterisk-org-access-app bot pushed a commit that referenced this issue Sep 6, 2023
If the called party hangs up while digits are being
sent, -1 is returned to indicate so, but app_dial
was not checking the return value, resulting in
the hangup being lost and looping forever until
the caller manually hangs up the channel. We now
abort if digit sending fails.

ASTERISK-29428 #close

Resolves: #281
(cherry picked from commit c032d38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug support-level-core Functionality with core support level
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants