Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: Existence of logger.xml causes linking failure #539

Closed
1 task done
InterLinked1 opened this issue Jan 16, 2024 · 0 comments · Fixed by #540
Closed
1 task done

[bug]: Existence of logger.xml causes linking failure #539

InterLinked1 opened this issue Jan 16, 2024 · 0 comments · Fixed by #540
Assignees
@InterLinked1
Labels
bug regression support-level-core Functionality with core support level

Comments

@InterLinked1
Copy link
Contributor

Severity

Critical

Versions

21.1.0-rc1

Components/Modules

logger.xml

Operating Environment

Debian 12

Frequency of Occurrence

Constant

Issue Description

Commit 008731b caused a regression by creating a .xml file named the same as a .c file, causing linking errors with logger.o

This causes failure to link the asterisk binary on certain platforms - it will consistently fail on certain platforms (e.g. for me), though not for others. However, according to @gtjoseph this is likely due to there being two rules, one from %c. and one from %.xml:

This leads to trying to compile logger.xml instead of logger.c, resulting in linking failure due to missing symbols. The existing xml files didn't cause this because they were all named differently from any .c files in the same directory.

To fix this, we simply rename the file to avoid a conflict.

objdump -t main/logger.o

main/logger.o:     file format elf64-x86-64

SYMBOL TABLE:
0000000000000000 l    d  .data  0000000000000000 .data
0000000000000000 l    d  .note.GNU-stack        0000000000000000 .note.GNU-stack
0000000000000708 g       .data  0000000000000000 _binary_logger_xml_end
0000000000000708 g       *ABS*  0000000000000000 _binary_logger_xml_size
0000000000000000 g       .data  0000000000000000 _binary_logger_xml_start

Relevant log output

No response

Asterisk Issue Guidelines

  • Yes, I have read the Asterisk Issue Guidelines
InterLinked1 added a commit to InterLinked1/asterisk that referenced this issue Jan 16, 2024
@InterLinked1
logger: Fix linking regression.
6b26ffb 
Commit 008731b
caused a regression by resulting in logger.xml
being compiled and linked into the asterisk
binary in lieu of logger.c on certain platforms.

To fix this, we ensure the file has a unique
name without the extension. Most existing .xml
files have been named differently from any
.c files in the same directory or did not
pose this issue.

channels/pjsip/dialplan_functions.xml does not
pose this issue but is also being renamed
to adhere to this policy.

Resolves: asterisk#539
@InterLinked1 InterLinked1 mentioned this issue Jan 16, 2024
Merged
InterLinked1 added a commit to InterLinked1/asterisk that referenced this issue Jan 16, 2024
@InterLinked1
logger: Fix linking regression.
d6a3020 
Commit 008731b
caused a regression by resulting in logger.xml
being compiled and linked into the asterisk
binary in lieu of logger.c on certain platforms
if Asterisk was compiled in dev mode.

To fix this, we ensure the file has a unique
name without the extension. Most existing .xml
files have been named differently from any
.c files in the same directory or did not
pose this issue.

channels/pjsip/dialplan_functions.xml does not
pose this issue but is also being renamed
to adhere to this policy.

Resolves: asterisk#539
@jcolp jcolp added support-level-core Functionality with core support level regression and removed triage labels Jan 17, 2024
asterisk-org-access-app bot pushed a commit that referenced this issue Jan 17, 2024
@InterLinked1
logger: Fix linking regression.
395c674 
Commit 008731b
caused a regression by resulting in logger.xml
being compiled and linked into the asterisk
binary in lieu of logger.c on certain platforms
if Asterisk was compiled in dev mode.

To fix this, we ensure the file has a unique
name without the extension. Most existing .xml
files have been named differently from any
.c files in the same directory or did not
pose this issue.

channels/pjsip/dialplan_functions.xml does not
pose this issue but is also being renamed
to adhere to this policy.

Resolves: #539
asterisk-org-access-app bot pushed a commit that referenced this issue Jan 17, 2024
@InterLinked1
logger: Fix linking regression.
2b587d1 
Commit 008731b
caused a regression by resulting in logger.xml
being compiled and linked into the asterisk
binary in lieu of logger.c on certain platforms
if Asterisk was compiled in dev mode.

To fix this, we ensure the file has a unique
name without the extension. Most existing .xml
files have been named differently from any
.c files in the same directory or did not
pose this issue.

channels/pjsip/dialplan_functions.xml does not
pose this issue but is also being renamed
to adhere to this policy.

Resolves: #539
asterisk-org-access-app bot pushed a commit that referenced this issue Jan 17, 2024
@InterLinked1
logger: Fix linking regression.
6fd6f22 
Commit 008731b
caused a regression by resulting in logger.xml
being compiled and linked into the asterisk
binary in lieu of logger.c on certain platforms
if Asterisk was compiled in dev mode.

To fix this, we ensure the file has a unique
name without the extension. Most existing .xml
files have been named differently from any
.c files in the same directory or did not
pose this issue.

channels/pjsip/dialplan_functions.xml does not
pose this issue but is also being renamed
to adhere to this policy.

Resolves: #539
asterisk-org-access-app bot pushed a commit that referenced this issue Jan 17, 2024
@InterLinked1 @asterisk-org-access-app
logger: Fix linking regression.
ac71e40 
Commit 008731b
caused a regression by resulting in logger.xml
being compiled and linked into the asterisk
binary in lieu of logger.c on certain platforms
if Asterisk was compiled in dev mode.

To fix this, we ensure the file has a unique
name without the extension. Most existing .xml
files have been named differently from any
.c files in the same directory or did not
pose this issue.

channels/pjsip/dialplan_functions.xml does not
pose this issue but is also being renamed
to adhere to this policy.

Resolves: #539
mbradeen pushed a commit that referenced this issue Jan 18, 2024
@InterLinked1 @mbradeen
logger: Fix linking regression.
b9373a2 
Commit 008731b
caused a regression by resulting in logger.xml
being compiled and linked into the asterisk
binary in lieu of logger.c on certain platforms
if Asterisk was compiled in dev mode.

To fix this, we ensure the file has a unique
name without the extension. Most existing .xml
files have been named differently from any
.c files in the same directory or did not
pose this issue.

channels/pjsip/dialplan_functions.xml does not
pose this issue but is also being renamed
to adhere to this policy.

Resolves: #539
mbradeen pushed a commit that referenced this issue Jan 18, 2024
@InterLinked1 @mbradeen
logger: Fix linking regression.
87fb290 
Commit 008731b
caused a regression by resulting in logger.xml
being compiled and linked into the asterisk
binary in lieu of logger.c on certain platforms
if Asterisk was compiled in dev mode.

To fix this, we ensure the file has a unique
name without the extension. Most existing .xml
files have been named differently from any
.c files in the same directory or did not
pose this issue.

channels/pjsip/dialplan_functions.xml does not
pose this issue but is also being renamed
to adhere to this policy.

Resolves: #539
mbradeen pushed a commit that referenced this issue Jan 18, 2024
@InterLinked1 @mbradeen
logger: Fix linking regression.
e735ab8 
Commit 008731b
caused a regression by resulting in logger.xml
being compiled and linked into the asterisk
binary in lieu of logger.c on certain platforms
if Asterisk was compiled in dev mode.

To fix this, we ensure the file has a unique
name without the extension. Most existing .xml
files have been named differently from any
.c files in the same directory or did not
pose this issue.

channels/pjsip/dialplan_functions.xml does not
pose this issue but is also being renamed
to adhere to this policy.

Resolves: #539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@InterLinked1 InterLinked1

Labels
bug regression support-level-core Functionality with core support level
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

logger: Fix linking regression. InterLinked1/asterisk
2 participants
@jcolp @InterLinked1