You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[bug]: Existence of logger.xml causes linking failure #539
Commit 008731b caused a regression by creating a .xml file named the same as a .c file, causing linking errors with logger.o
This causes failure to link the asterisk binary on certain platforms - it will consistently fail on certain platforms (e.g. for me), though not for others. However, according to @gtjoseph this is likely due to there being two rules, one from %c. and one from %.xml:
This leads to trying to compile logger.xml instead of logger.c, resulting in linking failure due to missing symbols. The existing xml files didn't cause this because they were all named differently from any .c files in the same directory.
To fix this, we simply rename the file to avoid a conflict.
objdump -t main/logger.o
main/logger.o: file format elf64-x86-64
SYMBOL TABLE:
0000000000000000 l d .data 0000000000000000 .data
0000000000000000 l d .note.GNU-stack 0000000000000000 .note.GNU-stack
0000000000000708 g .data 0000000000000000 _binary_logger_xml_end
0000000000000708 g *ABS* 0000000000000000 _binary_logger_xml_size
0000000000000000 g .data 0000000000000000 _binary_logger_xml_start
Activity
logger: Fix linking regression.
logger: Fix linking regression.
logger: Fix linking regression.
logger: Fix linking regression.
logger: Fix linking regression.
logger: Fix linking regression.
logger: Fix linking regression.
logger: Fix linking regression.
logger: Fix linking regression.