Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improvement]: Endpoint identifier request line #599

Closed
viktike opened this issue Feb 12, 2024 · 4 comments · Fixed by #600
Closed

[improvement]: Endpoint identifier request line #599

viktike opened this issue Feb 12, 2024 · 4 comments · Fixed by #600
Assignees
@viktike
Labels
improvement support-level-core Functionality with core support level

Comments

@viktike
Copy link
Contributor

viktike commented Feb 12, 2024

Improvement Description

I've encountered a strange SIP setup, and needed to match and endpoint not even by header, but the request line (first line of the SIP message). Therefor I wrote a small patch to res_pjsip_endpoint_identifier_ip module to handle this (attached). It works like matching any other SIP header (eg.: exact match or regular expression), but instead of the header's name, the keyword "request" can be set. Like:

match_header=Request:/.172.28.129.195./

pjsip_endpoint_identifier_header_request_line.patch
@viktike viktike changed the title [improvement]: [improvement]: Endpoint identifier request line Feb 12, 2024
@jcolp
Copy link
Member

jcolp commented Feb 12, 2024

Changes are not accepted as attachments. They need to go as a pull request with a signed contributor license agreement.

@viktike
Copy link
Contributor Author

viktike commented Feb 12, 2024

Thanks, here it is: #600

@viktike viktike closed this as not planned Won't fix, can't repro, duplicate, stale Feb 12, 2024
@seanbright
Copy link
Contributor

@viktike you should leave this issue open and then reference it in your commit message like:

Fixes #599

@gtjoseph gtjoseph reopened this Feb 12, 2024
@viktike
Copy link
Contributor Author

viktike commented Feb 12, 2024

Here is another one: #602 (last one, I promise)

@gtjoseph gtjoseph mentioned this issue Feb 14, 2024
Merged
viktike added a commit to viktike/asterisk that referenced this issue Feb 14, 2024
@viktike
res_pjsip_endpoint_identifier_ip: Endpoint identifier request line
2a2ad23 
Add ability to match against PJSIP request line.
Use the 'request' key in the match_header field.

Fixes: asterisk#599
@jcolp jcolp added support-level-core Functionality with core support level and removed triage labels Feb 27, 2024
viktike added a commit to viktike/asterisk that referenced this issue Mar 2, 2024
@viktike
res_pjsip_endpoint_identifier_ip: Endpoint identifier request URI
82f3f53 
Add ability to match against PJSIP request URI.
Use the 'request_uri' identifier in the identify_by field.

Fixes: asterisk#599
viktike added a commit to viktike/asterisk that referenced this issue Mar 12, 2024
@viktike
res_pjsip_endpoint_identifier_ip: Endpoint identifier request URI
970839c 
Add ability to match against PJSIP request URI.
Use the 'request_uri' identifier in the identify_by field.

Fixes: asterisk#599
viktike added a commit to viktike/asterisk that referenced this issue Mar 25, 2024
@viktike
res_pjsip_endpoint_identifier_ip: Endpoint identifier request URI
4b3800f 
Add ability to match against PJSIP request URI.
Use the 'request_uri' identifier in the identify_by field.

Fixes: asterisk#599
viktike added a commit to viktike/asterisk that referenced this issue Mar 26, 2024
@viktike
res_pjsip_endpoint_identifier_ip: Endpoint identifier request URI
fe26bf4 
Add ability to match against PJSIP request URI.

UserNote: this new feature let users match endpoints based on the
indound SIP requests' URI. To do so, add 'request_uri' to the
endpoint's 'identify_by' option. The 'match_request_uri' option of
the identify can be an exact match for the entire request uri, or a
regular expression (between slashes). It's quite similar to the
header identifer.

Fixes: asterisk#599
viktike added a commit to viktike/asterisk that referenced this issue Mar 26, 2024
@viktike
res_pjsip_endpoint_identifier_ip: Endpoint identifier request URI
2749cb6 
Add ability to match against PJSIP request URI.

UserNote: this new feature let users match endpoints based on the
indound SIP requests' URI. To do so, add 'request_uri' to the
endpoint's 'identify_by' option. The 'match_request_uri' option of
the identify can be an exact match for the entire request uri, or a
regular expression (between slashes). It's quite similar to the
header identifer.

Fixes: asterisk#599
viktike added a commit to viktike/asterisk that referenced this issue Mar 28, 2024
@viktike
res_pjsip_endpoint_identifier_ip: Endpoint identifier request URI
35805f9 
Add ability to match against PJSIP request URI.

UserNote: this new feature let users match endpoints based on the
indound SIP requests' URI. To do so, add 'request_uri' to the
endpoint's 'identify_by' option. The 'match_request_uri' option of
the identify can be an exact match for the entire request uri, or a
regular expression (between slashes). It's quite similar to the
header identifer.

Fixes: asterisk#599
asterisk-org-access-app bot pushed a commit that referenced this issue Mar 28, 2024
@viktike
res_pjsip_endpoint_identifier_ip: Endpoint identifier request URI
ac297d1 
Add ability to match against PJSIP request URI.

UserNote: this new feature let users match endpoints based on the
indound SIP requests' URI. To do so, add 'request_uri' to the
endpoint's 'identify_by' option. The 'match_request_uri' option of
the identify can be an exact match for the entire request uri, or a
regular expression (between slashes). It's quite similar to the
header identifer.

Fixes: #599
asterisk-org-access-app bot pushed a commit that referenced this issue Mar 28, 2024
@viktike
res_pjsip_endpoint_identifier_ip: Endpoint identifier request URI
136bd5c 
Add ability to match against PJSIP request URI.

UserNote: this new feature let users match endpoints based on the
indound SIP requests' URI. To do so, add 'request_uri' to the
endpoint's 'identify_by' option. The 'match_request_uri' option of
the identify can be an exact match for the entire request uri, or a
regular expression (between slashes). It's quite similar to the
header identifer.

Fixes: #599
asterisk-org-access-app bot pushed a commit that referenced this issue Mar 28, 2024
@viktike
res_pjsip_endpoint_identifier_ip: Endpoint identifier request URI
83f1317 
Add ability to match against PJSIP request URI.

UserNote: this new feature let users match endpoints based on the
indound SIP requests' URI. To do so, add 'request_uri' to the
endpoint's 'identify_by' option. The 'match_request_uri' option of
the identify can be an exact match for the entire request uri, or a
regular expression (between slashes). It's quite similar to the
header identifer.

Fixes: #599
asterisk-org-access-app bot pushed a commit that referenced this issue Mar 28, 2024
@viktike @asterisk-org-access-app
res_pjsip_endpoint_identifier_ip: Endpoint identifier request URI
895ab9d 
Add ability to match against PJSIP request URI.

UserNote: this new feature let users match endpoints based on the
indound SIP requests' URI. To do so, add 'request_uri' to the
endpoint's 'identify_by' option. The 'match_request_uri' option of
the identify can be an exact match for the entire request uri, or a
regular expression (between slashes). It's quite similar to the
header identifer.

Fixes: #599
asterisk-org-access-app bot pushed a commit that referenced this issue May 9, 2024
@viktike @asteriskteam
res_pjsip_endpoint_identifier_ip: Endpoint identifier request URI
7797555 
Add ability to match against PJSIP request URI.

UserNote: this new feature let users match endpoints based on the
indound SIP requests' URI. To do so, add 'request_uri' to the
endpoint's 'identify_by' option. The 'match_request_uri' option of
the identify can be an exact match for the entire request uri, or a
regular expression (between slashes). It's quite similar to the
header identifer.

Fixes: #599
(cherry picked from commit 83f1317)
asterisk-org-access-app bot pushed a commit that referenced this issue May 9, 2024
@viktike @asteriskteam
res_pjsip_endpoint_identifier_ip: Endpoint identifier request URI
d225500 
Add ability to match against PJSIP request URI.

UserNote: this new feature let users match endpoints based on the
indound SIP requests' URI. To do so, add 'request_uri' to the
endpoint's 'identify_by' option. The 'match_request_uri' option of
the identify can be an exact match for the entire request uri, or a
regular expression (between slashes). It's quite similar to the
header identifer.

Fixes: #599
(cherry picked from commit ac297d1)
asterisk-org-access-app bot pushed a commit that referenced this issue May 9, 2024
@viktike @asteriskteam
res_pjsip_endpoint_identifier_ip: Endpoint identifier request URI
bd3c3bf 
Add ability to match against PJSIP request URI.

UserNote: this new feature let users match endpoints based on the
indound SIP requests' URI. To do so, add 'request_uri' to the
endpoint's 'identify_by' option. The 'match_request_uri' option of
the identify can be an exact match for the entire request uri, or a
regular expression (between slashes). It's quite similar to the
header identifer.

Fixes: #599
(cherry picked from commit 136bd5c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viktike viktike

Labels
improvement support-level-core Functionality with core support level
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

res_pjsip_endpoint_identifier_ip: Endpoint identifier request URI viktike/asterisk
4 participants
@seanbright @jcolp @gtjoseph @viktike