Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: Possible SEGV in res_stir_shaken due to wrong free function #636

Closed
1 task done
gtjoseph opened this issue Mar 5, 2024 · 0 comments · Fixed by #637
Closed
1 task done

[bug]: Possible SEGV in res_stir_shaken due to wrong free function #636

gtjoseph opened this issue Mar 5, 2024 · 0 comments · Fixed by #637
Assignees
@gtjoseph
Labels
bug support-level-core Functionality with core support level

Comments

@gtjoseph
Copy link
Member

gtjoseph commented Mar 5, 2024

Severity

Blocker

Versions

18,20,21,master

Components/Modules

res_stir_shaken

Operating Environment

all

Frequency of Occurrence

None

Issue Description

In attestation_config:as_check_common_config is calling ast_std_free instead of ast_free on raw_key which can cause a SEGV if MALLOC_DEBUG is enabled.

Relevant log output

No response

Asterisk Issue Guidelines

  • Yes, I have read the Asterisk Issue Guidelines
@gtjoseph gtjoseph self-assigned this Mar 5, 2024
@gtjoseph gtjoseph added support-level-core Functionality with core support level and removed triage labels Mar 5, 2024
gtjoseph added a commit to gtjoseph/asterisk that referenced this issue Mar 5, 2024
@gtjoseph
attestation_config.c: Use ast_free instead of ast_std_free
5c146fb 
In as_check_common_config, we were calling ast_std_free on
raw_key but raw_key was allocated with ast_malloc so it
should be freed with ast_free.

Resolves: asterisk#636
@gtjoseph gtjoseph mentioned this issue Mar 5, 2024
Merged
asterisk-org-access-app bot pushed a commit that referenced this issue Mar 5, 2024
@gtjoseph
attestation_config.c: Use ast_free instead of ast_std_free
5446432 
In as_check_common_config, we were calling ast_std_free on
raw_key but raw_key was allocated with ast_malloc so it
should be freed with ast_free.

Resolves: #636
asterisk-org-access-app bot pushed a commit that referenced this issue Mar 5, 2024
@gtjoseph
attestation_config.c: Use ast_free instead of ast_std_free
267348b 
In as_check_common_config, we were calling ast_std_free on
raw_key but raw_key was allocated with ast_malloc so it
should be freed with ast_free.

Resolves: #636
asterisk-org-access-app bot pushed a commit that referenced this issue Mar 5, 2024
@gtjoseph
attestation_config.c: Use ast_free instead of ast_std_free
1b94c90 
In as_check_common_config, we were calling ast_std_free on
raw_key but raw_key was allocated with ast_malloc so it
should be freed with ast_free.

Resolves: #636
asterisk-org-access-app bot pushed a commit that referenced this issue Mar 5, 2024
@gtjoseph @asterisk-org-access-app
attestation_config.c: Use ast_free instead of ast_std_free
d478002 
In as_check_common_config, we were calling ast_std_free on
raw_key but raw_key was allocated with ast_malloc so it
should be freed with ast_free.

Resolves: #636
asterisk-org-access-app bot pushed a commit that referenced this issue Mar 7, 2024
@gtjoseph @asteriskteam
attestation_config.c: Use ast_free instead of ast_std_free
0c879c6 
In as_check_common_config, we were calling ast_std_free on
raw_key but raw_key was allocated with ast_malloc so it
should be freed with ast_free.

Resolves: #636
(cherry picked from commit 5446432)
asterisk-org-access-app bot pushed a commit that referenced this issue Mar 7, 2024
@gtjoseph @asteriskteam
attestation_config.c: Use ast_free instead of ast_std_free
44563b5 
In as_check_common_config, we were calling ast_std_free on
raw_key but raw_key was allocated with ast_malloc so it
should be freed with ast_free.

Resolves: #636
(cherry picked from commit 267348b)
asterisk-org-access-app bot pushed a commit that referenced this issue Mar 7, 2024
@gtjoseph @asteriskteam
attestation_config.c: Use ast_free instead of ast_std_free
c085753 
In as_check_common_config, we were calling ast_std_free on
raw_key but raw_key was allocated with ast_malloc so it
should be freed with ast_free.

Resolves: #636
(cherry picked from commit 1b94c90)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gtjoseph gtjoseph

Labels
bug support-level-core Functionality with core support level
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

attestation_config.c: Use ast_free instead of ast_std_free gtjoseph/asterisk
1 participant
@gtjoseph