app_voicemail - add manager actions to display and manipulate messages #182

mbradeen · 2023-06-29T18:26:45Z

Adds manager actions to allow move/remove/forward individual messages in a particular mailbox folder. The forward command can be used to copy a message within a mailbox or to another mailbox. Also adds a VoicemailBoxSummarry, required to retrieve message ID's.

Resolves: #181

UserNote: The following manager actions have been added

VoicemailBoxSummary - Generate message list for a given mailbox

VoicemailRemove - Remove a message from a mailbox folder

VoicemailMove - Move a message from one folder to another within a mailbox

VoicemailForward - Copy a message from one folder in one mailbox
to another folder in another or the same mailbox.

asterisk-org-access-app · 2023-06-29T18:27:49Z

REMINDER: If this PR applies to other branches, please add a comment with the appropriate "cherry-pick-to" headers as per the Create a Pull Request process.

If you don't want it cherry-picked, please add a comment stating "No cherry-picks required" so we don't keep asking.

If, after adding "cherry-pick-to" comments, you change your mind, please edit the comment to DELETE the header lines and add "No cherry-picks required".

mbradeen · 2023-06-29T18:29:37Z

cherry-pick-to: 20
cherry-pick-to: 18
cherry-pick-to: certified/18.9

mbradeen · 2023-06-30T14:52:53Z

Example commands and output:
Get mailbox contents-

'VoicemailBoxSummary',
  Context='default',
  Mailbox='1000'

Response: Success
ActionID: 1
EventList: start
Message: Voicemail box detail will follow

Event : VoicemailBoxDetail -> {'ActionID': '1', 'Folder': 'INBOX', 'CallerID': '"Carrot" <1002>', 'Date': 'Tue Jun 20 03:59:44 PM UTC 2023', 'Duration': '0', 'Flag': '', 'ID': '1687276784-00000001'}
Event : VoicemailBoxDetail -> {'ActionID': '1', 'Folder': 'Old', 'CallerID': '"Carrot" <1002>', 'Date': 'Tue Jun 20 03:59:11 PM UTC 2023', 'Duration': '0', 'Flag': '', 'ID': '1687276751-00000000'}
Event : VoicemailBoxDetail -> {'ActionID': '1', 'Folder': 'Work', 'CallerID': '"Carrot" <1002>', 'Date': 'Tue Jun 20 04:00:03 PM UTC 2023', 'Duration': '0', 'Flag': '', 'ID': '1687276803-00000002'}
Event : VoicemailBoxDetailComplete -> {'ActionID': '1', 'EventList': 'Complete', 'ListItems': '3'}

Move a message from 'Urgent' to 'Inbox'

'VoicemailMove',
  Context='default',
  Mailbox='1000',
  Folder='Urgent',
  ID='1687276784-00000011',
  ToFolder='INBOX'

Response: Success
ActionID: 1
Message: Message move successful

Event : MessageWaiting -> {'Privilege': 'call,all', 'SequenceNumber': '12', 'File': 'manager_mwi.c', 'Line': '136', 'Func': 'mwi_update_cb', 'Mailbox': '1000@default', 'Waiting': '1', 'New': '1', 'Old': '1'}

jcolp · 2023-07-05T09:27:13Z

apps/app_voicemail.c

+	struct ast_vm_msg_snapshot *msg;
+	int n = 0;
+
+	if((s == NULL) || (vmu == NULL) || (event_name == NULL) || (actionid == NULL)) {


This doesn't conform to our coding guidelines

jcolp · 2023-07-05T09:27:25Z

apps/app_voicemail.c

+	int n = 0;
+
+	if((s == NULL) || (vmu == NULL) || (event_name == NULL) || (actionid == NULL)) {
+		ast_log(LOG_ERROR, "Wrong input parameter.");


This is not useful as an error message within the content of this work

jcolp · 2023-07-05T09:27:39Z

apps/app_voicemail.c

+	}
+
+	/* Take a snapshot of the mailbox and walk through each folder's contents */
+	if ((mailbox_snapshot = ast_vm_mailbox_snapshot_create(vmu->mailbox, vmu->context, NULL, 0, AST_VM_SNAPSHOT_SORT_BY_ID, 0))) {


Reduce indentation by returning -1 early if no mailbox snapshot

apps/app_voicemail.c

jcolp · 2023-07-11T13:45:08Z

apps/app_voicemail.c

+	/* walk through user's mailbox and append info for each message */
+	nummessages = append_vmbox_info_astman(s, vmu, "VoicemailBoxDetail", actionid);
+	if(nummessages < 0) {
+		ast_log(LOG_ERROR, "Could not append voicemail box info.");


This doesn't contain enough information to be useful, such as the mailbox and context

jcolp · 2023-07-11T13:45:16Z

apps/app_voicemail.c

+
+	/* walk through user's mailbox and append info for each message */
+	nummessages = append_vmbox_info_astman(s, vmu, "VoicemailBoxDetail", actionid);
+	if(nummessages < 0) {


if (nummessages < 0) {

jcolp · 2023-07-11T13:46:56Z

apps/app_voicemail.c

+	nummessages = append_vmbox_info_astman(s, vmu, "VoicemailBoxDetail", actionid);
+	if(nummessages < 0) {
+		ast_log(LOG_ERROR, "Could not append voicemail box info.");
+		nummessages = 0;


If this fails part way through, what will the result be? Some details sent, but a total messages count of 0?

in a particular mailbox folder. The forward command can be used to copy a message within a mailbox or to another mailbox. Also adds a VoicemailBoxSummarry, required to retrieve message ID's. Resolves: asterisk#181 UserNote: The following manager actions have been added VoicemailBoxSummary - Generate message list for a given mailbox VoicemailRemove - Remove a message from a mailbox folder VoicemailMove - Move a message from one folder to another within a mailbox VoicemailForward - Copy a message from one folder in one mailbox to another folder in another or the same mailbox.

github-actions · 2023-07-12T17:37:44Z

Successfully merged to branch master and cherry-picked to ["20","18","certified/18.9"]

asterisk-org-access-app bot requested a review from a team June 29, 2023 18:27

github-actions bot added the testing-in-progress label Jun 29, 2023

github-actions bot added test-checks-passed test-gates-failed and removed testing-in-progress labels Jun 29, 2023

mbradeen force-pushed the master-issue-181 branch from ae37f6d to 790c3e6 Compare June 30, 2023 15:08

github-actions bot added testing-in-progress test-checks-passed test-gates-passed and removed test-checks-passed test-gates-failed testing-in-progress labels Jun 30, 2023

jcolp requested changes Jul 5, 2023

View reviewed changes

mbradeen force-pushed the master-issue-181 branch from 790c3e6 to 8163e8b Compare July 6, 2023 18:26

github-actions bot added testing-in-progress test-checks-passed test-gates-passed and removed test-checks-passed test-gates-passed testing-in-progress labels Jul 6, 2023

mbradeen requested a review from jcolp July 10, 2023 19:41

jcolp requested changes Jul 11, 2023

View reviewed changes

mbradeen force-pushed the master-issue-181 branch from 8163e8b to 89ff4c5 Compare July 11, 2023 20:36

github-actions bot added testing-in-progress and removed test-checks-passed labels Jul 11, 2023

github-actions bot added test-checks-passed test-gates-passed and removed test-gates-passed testing-in-progress labels Jul 11, 2023

mbradeen requested a review from jcolp July 11, 2023 21:14

jcolp approved these changes Jul 12, 2023

View reviewed changes

gtjoseph added the cherry-pick-test Trigger dry run of cherry-picks label Jul 12, 2023

gtjoseph approved these changes Jul 12, 2023

View reviewed changes

gtjoseph added the merge-approved label Jul 12, 2023

github-actions bot added pre-merge-testing-in-progress pre-merge-checks-passed merge-in-progress and removed merge-approved pre-merge-testing-in-progress labels Jul 12, 2023

asterisk-org-access-app bot merged commit eef5a0b into asterisk:master Jul 12, 2023
58 of 61 checks passed

github-actions bot removed the merge-in-progress label Jul 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

app_voicemail - add manager actions to display and manipulate messages #182

app_voicemail - add manager actions to display and manipulate messages #182

mbradeen commented Jun 29, 2023 •

edited

asterisk-org-access-app bot commented Jun 29, 2023

mbradeen commented Jun 29, 2023

mbradeen commented Jun 30, 2023 •

edited

jcolp Jul 5, 2023

jcolp Jul 5, 2023

jcolp Jul 5, 2023

jcolp Jul 11, 2023

jcolp Jul 11, 2023

jcolp Jul 11, 2023

github-actions bot commented Jul 12, 2023

app_voicemail - add manager actions to display and manipulate messages #182

app_voicemail - add manager actions to display and manipulate messages #182

Conversation

mbradeen commented Jun 29, 2023 • edited

asterisk-org-access-app bot commented Jun 29, 2023

mbradeen commented Jun 29, 2023

mbradeen commented Jun 30, 2023 • edited

jcolp Jul 5, 2023

Choose a reason for hiding this comment

jcolp Jul 5, 2023

Choose a reason for hiding this comment

jcolp Jul 5, 2023

Choose a reason for hiding this comment

jcolp Jul 11, 2023

Choose a reason for hiding this comment

jcolp Jul 11, 2023

Choose a reason for hiding this comment

jcolp Jul 11, 2023

Choose a reason for hiding this comment

github-actions bot commented Jul 12, 2023

mbradeen commented Jun 29, 2023 •

edited

mbradeen commented Jun 30, 2023 •

edited