sig_analog: Allow three-way flash to time out to silence. #206
Conversation
|
cherry-pick-to: 20 |
|
REMINDER: If this PR applies to other branches, please add a comment with the appropriate "cherry-pick-to" headers as per the Create a Pull Request process. If you don't want it cherry-picked, please add a comment stating "No cherry-picks required" so we don't keep asking. If, after adding "cherry-pick-to" comments, you change your mind, please edit the comment to DELETE the header lines and add "No cherry-picks required". |
github-actions
bot
added
testing-in-progress
test-checks-passed
test-gates-passed
and removed
testing-in-progress
labels
There was a problem hiding this comment.
Per https://docs.asterisk.org/latest/Development/Policies-and-Procedures/Commit-Messages/ Please do NOT intersperse unsupported commit message trailers among the supported ones. The "ASTERISK-30004..." line MUST come before the standard Resolves, Usernote and UpgradeNote trailers.
sig_analog allows users to flash and use the three-way dial tone as a primitive hold function, simply by never timing it out. Some systems allow this dial tone to time out to silence, so the user is not annoyed by a persistent dial tone. This option allows the dial tone to time out normally to silence. ASTERISK-30004 #close Resolves: asterisk#205 UserNote: The threewaysilenthold option now allows the three-way dial tone to time out to silence, rather than continuing forever.
InterLinked1
force-pushed
the
master-issue-205
branch
from
d894812 to
c1774cc
Compare
https://docs.asterisk.org/latest/Development/Policies-and-Procedures/Commit-Messages/ is a 404, but should be fixed now! |
github-actions
bot
added
testing-in-progress
and removed
test-checks-passed
test-gates-passed
labels
github-actions
bot
added
test-checks-passed
test-gates-passed
and removed
testing-in-progress
labels
|
@gtjoseph By the way, I think the same thing has happened here: for some reason, GitHub isn't discussing the stale feedback for an addressed issue, so I'm assuming this probably isn't showing up in the "needs attention queue" or however it works (since it says "Changes requested" which is wrong). But it only seems to happen sometimes, not all the time, trying to see what that might be. Could be my fault since I acknowledged it, maybe I shouldn't be doing that. |
|
Ok. I'll re-review in a bit. |
github-actions
bot
added
cherry-pick-testing-in-progress
github-actions
bot
added
pre-merge-testing-in-progress
pre-merge-checks-passed
merge-in-progress
and removed
pre-merge-testing-in-progress
labels
|
Successfully merged to branch master and cherry-picked to ["20","18"] |
sig_analog allows users to flash and use the three-way dial tone as a primitive hold function, simply by never timing it out.
Some systems allow this dial tone to time out to silence, so the user is not annoyed by a persistent dial tone. This option allows the dial tone to time out normally to silence.
Resolves: #205
ASTERISK-30004 #close
Imported from Gerrit: https://gerrit.asterisk.org/c/asterisk/+/19716
UserNote: The threewaysilenthold option now allows the three-way dial tone to time out to silence, rather than continuing forever.