app_dial: Add dial time for progress/ringing. #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cherry-pick-to: 18 |
github-actions
bot
added
pr-submit-testing-in-progress
pr-submit-tests-passed
and removed
pr-submit-testing-in-progress
labels
|
The use of pipe as argument separator is discouraged, per conversation at AstriCon. (It was used before the switch to comma many ages ago.) Maybe try caret ? @jcolp |
jcolp
requested changes
Feb 28, 2024
Add a timeout option to control the amount of time to wait if no early media is received before giving up. This allows aborting early if the destination is not being responsive. Resolves: asterisk#588 UserNote: The timeout argument to Dial now allows specifying the maximum amount of time to dial if early media is not received.
InterLinked1
force-pushed
the
master-issue-588
branch
from
46f438b
to
daf871b
Compare
github-actions
bot
added
pr-submit-testing-in-progress
pr-submit-tests-failed
and removed
pr-submit-tests-passed
pr-submit-testing-in-progress
labels
|
Tests added here: asterisk/testsuite#44 |
jcolp
approved these changes
Mar 4, 2024
github-actions
bot
added
cherry-pick-testing-in-progress
github-actions
bot
added
cherry-pick-testing-in-progress
github-actions
bot
added
pre-merge-testing-in-progress
pre-merge-checks-passed
merge-in-progress
and removed
merge-approved
pre-merge-testing-in-progress
labels
asterisk-org-access-app
bot
merged commit 320c98e
into
asterisk:master
79 of 99 checks passed
|
Successfully merged to branch master and cherry-picked to ["18","20","21"] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a timeout option to control the amount of time to wait if no early media is received before giving up. This allows aborting early if the destination
is not being responsive.
Resolves: #588
UserNote: The timeout argument to Dial now allows
specifying the maximum amount of time to dial if
early media is not received.