callerid.c: Parse previously ignored Caller ID parameters. #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cherry-pick-to: 18 |
InterLinked1
force-pushed
the
master-issue-681
branch
from
c46e72b
to
e574d1a
Compare
github-actions
bot
added
pr-submit-tests-failed
and removed
pr-submit-testing-in-progress
labels
InterLinked1
force-pushed
the
master-issue-681
branch
from
e574d1a
to
73eaa48
Compare
github-actions
bot
added
pr-submit-testing-in-progress
pr-submit-tests-passed
and removed
pr-submit-tests-failed
pr-submit-testing-in-progress
labels
seanbright
reviewed
Apr 4, 2024
Commit f2f397c previously made it possible to send Caller ID parameters to FXS stations which, prior to that, could not be sent. This change is complementary in that we now handle receiving all these parameters on FXO lines and provide these up to the dialplan, via chan_dahdi. In particular: * If a redirecting reason is provided, the channel's redirecting reason is set. No redirecting number is set, since there is no parameter for this in the Caller ID protocol, but the reason can be checked to determine if and why a call was forwarded. * If the Call Qualifier parameter is received, the Call Qualifier variable is set. * Some comments have been added to explain why some of the code is the way it is, to assist other people looking at it. With this change, Asterisk's Caller ID implementation is now reasonably complete for both FXS and FXO operation. Resolves: asterisk#681
InterLinked1
force-pushed
the
master-issue-681
branch
from
73eaa48
to
eba9659
Compare
github-actions
bot
added
pr-submit-testing-in-progress
and removed
pr-submit-tests-passed
labels
github-actions
bot
added
pr-submit-tests-failed
and removed
pr-submit-testing-in-progress
labels
mbradeen
approved these changes
Apr 19, 2024
github-actions
bot
added
cherry-pick-testing-in-progress
jcolp
approved these changes
Apr 22, 2024
github-actions
bot
added
cherry-pick-checks-passed
github-actions
bot
added
pre-merge-testing-in-progress
and removed
merge-approved
labels
github-actions
bot
added
pre-merge-checks-passed
merge-in-progress
and removed
pre-merge-testing-in-progress
labels
asterisk-org-access-app
bot
merged commit c1b69d4
into
asterisk:master
60 of 62 checks passed
|
Successfully merged to branch master and cherry-picked to ["18","20","21"] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit f2f397c previously made it possible to send Caller ID parameters to FXS stations which, prior to that, could not be sent.
This change is complementary in that we now handle receiving all these parameters on FXO lines and provide these up to the dialplan, via chan_dahdi. In particular:
With this change, Asterisk's Caller ID implementation is now reasonably complete for both FXS and FXO operation.
Resolves: #681