Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

res/stasis/control.c: include signal.h #728

Merged
merged 1 commit into from
May 6, 2024

Conversation

ffontaine
Copy link
Contributor

@ffontaine ffontaine commented May 1, 2024

Include signal.h to avoid the following build failure with uclibc-ng raised since 2694792:

stasis/control.c: In function 'exec_command_on_condition': stasis/control.c:313:3: warning: implicit declaration of function 'pthread_kill'; did you mean 'pthread_yield'? [-Wimplicit-function-declaration]
  313 |   pthread_kill(control->control_thread, SIGURG);
      |   ^~~~~~~~~~~~
      |   pthread_yield
stasis/control.c:313:41: error: 'SIGURG' undeclared (first use in this function)
  313 |   pthread_kill(control->control_thread, SIGURG);
      |                                         ^~~~~~

Fixes: #729

Copy link

github-actions bot commented May 1, 2024

REMINDER: If this PR applies to other branches, please add a comment with the appropriate "cherry-pick-to" headers as per the Create a Pull Request process.

If you don't want it cherry-picked, please add a comment with cherry-pick-to: none so we don't keep asking.

If, after adding "cherry-pick-to" comments, you change your mind, please edit the comment to DELETE the header lines and add cherry-pick-to: none.

The currently active branches are now 18, 20, 21 and master.

@asteriskteam asteriskteam requested a review from a team May 1, 2024 15:17
Copy link
Member

@gtjoseph gtjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things to do...

  • Remove the 'Fixes" line since it doesn't reference a GitHub issue.
  • If not a trivial change (typo, documentation correction, etc) open an issue describing the problem.
  • Make sure the PR description and commit message reference the issue. See Commit Messages
  • If you still need the 'Signed-off-by' header, it must come before any "special" headers like Fixes, Resolves, UserNote, UpgradeNote. See Commit Messages
  • Add the appropriate "cherry-pick" PR comment. See Code Contribution

See:
https://docs.asterisk.org/Development/Policies-and-Procedures/Commit-Messages/
https://docs.asterisk.org/Development/Policies-and-Procedures/Coding-Guidelines/
https://docs.asterisk.org/Development/Policies-and-Procedures/Code-Contribution/

Include signal.h to avoid the following build failure with uclibc-ng
raised since
2694792:

stasis/control.c: In function 'exec_command_on_condition':
stasis/control.c:313:3: warning: implicit declaration of function 'pthread_kill'; did you mean 'pthread_yield'? [-Wimplicit-function-declaration]
  313 |   pthread_kill(control->control_thread, SIGURG);
      |   ^~~~~~~~~~~~
      |   pthread_yield
stasis/control.c:313:41: error: 'SIGURG' undeclared (first use in this function)
  313 |   pthread_kill(control->control_thread, SIGURG);
      |                                         ^~~~~~

cherry-pick-to: 18
cherry-pick-to: 20
cherry-pick-to: 21

Fixes: #729
@gtjoseph
Copy link
Member

gtjoseph commented May 6, 2024

@ffontaine For future reference, the cherry-pick lines have to be in a separate comment, not in the PR description.

@gtjoseph
Copy link
Member

gtjoseph commented May 6, 2024

cherry-pick-to: 18
cherry-pick-to: 20
cherry-pick-to: 21

@gtjoseph gtjoseph added the cherry-pick-test Trigger dry run of cherry-picks label May 6, 2024
@github-actions github-actions bot added cherry-pick-testing-in-progress Cherry-Pick tests in progress and removed cherry-pick-test Trigger dry run of cherry-picks labels May 6, 2024
@github-actions github-actions bot added cherry-pick-checks-passed Cherry-Pick checks passed cherry-pick-gates-failed Cherry-Pick gates failed and removed cherry-pick-testing-in-progress Cherry-Pick tests in progress labels May 6, 2024
@asterisk-org-access-app asterisk-org-access-app bot merged commit 7fc2528 into asterisk:master May 6, 2024
60 of 62 checks passed
Copy link

github-actions bot commented May 6, 2024

Successfully merged to branch master and cherry-picked to ["18","20","21"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Build failure with uclibc-ng
3 participants