Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app_followme: fix issue with enable_callee_prompt=no #88

Merged
merged 2 commits into from
Jun 5, 2023
Merged

app_followme: fix issue with enable_callee_prompt=no #88

merged 2 commits into from
Jun 5, 2023

Conversation

alex2grad
Copy link
Contributor

@alex2grad alex2grad commented May 16, 2023 •
edited

If the FollowMe option 'enable_callee_prompt' is set to 'no' then Asterisk
incorrectly sets a winner channel to the channel from which any control frame was read.

This fix sets the winner channel only to the answered channel.

Resolves: #87

ASTERISK-30326

@alex2grad
Copy link
Contributor Author

cherry-pick-to: 20
cherry-pick-to: 18

@gtjoseph gtjoseph closed this May 16, 2023
@gtjoseph gtjoseph reopened this May 16, 2023
@asterisk-org-access-app asterisk-org-access-app bot requested a review from a team May 16, 2023 22:40
InterLinked1
InterLinked1 suggested changes May 17, 2023
View reviewed changes
Copy link
Contributor

@InterLinked1 InterLinked1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub doesn't seem to allow commenting on commit messages like Gerrit does, so this is not inline:

asterisk -> Asterisk
incorretly -> incorrectly
from -> from which
channle -> channel
answred -> answered

@alex2grad
Copy link
Contributor Author

GitHub doesn't seem to allow commenting on commit messages like Gerrit does, so this is not inline:

asterisk -> Asterisk incorretly -> incorrectly from -> from which channle -> channel answred -> answered

done

@InterLinked1
Copy link
Contributor

GitHub doesn't seem to allow commenting on commit messages like Gerrit does, so this is not inline:
asterisk -> Asterisk incorretly -> incorrectly from -> from which channle -> channel answred -> answered

done

It isn't done; it was the commit message, not the PR message, to which I was referring.

@alex2grad
app_followme: fix issue with enable_callee_prompt=no
a1fec94 
If the FollowMe option 'enable_callee_prompt' is set to 'no' then Asterisk
incorrectly sets a winner channel to the channel from which any control frame was read.

This fix sets the winner channel only to the answered channel.

Resolves: asterisk#87

ASTERISK-30326
@alex2grad
Copy link
Contributor Author

GitHub doesn't seem to allow commenting on commit messages like Gerrit does, so this is not inline:
asterisk -> Asterisk incorretly -> incorrectly from -> from which channle -> channel answred -> answered

done

It isn't done; it was the commit message, not the PR message, to which I was referring.

done

@gtjoseph gtjoseph requested review from a team and removed request for InterLinked1 May 25, 2023 16:58
@gtjoseph gtjoseph added the cherry-pick-test Trigger dry run of cherry-picks label Jun 5, 2023
@github-actions github-actions bot added cherry-pick-testing-in-progress Cherry-Pick tests in progress cherry-pick-checks-passed Cherry-Pick checks passed cherry-pick-gates-failed Cherry-Pick gates failed and removed cherry-pick-test Trigger dry run of cherry-picks cherry-pick-testing-in-progress Cherry-Pick tests in progress labels Jun 5, 2023
@gtjoseph gtjoseph merged commit 8a6379f into asterisk:master Jun 5, 2023
38 of 41 checks passed
gtjoseph pushed a commit that referenced this pull request Jun 5, 2023
@alex2grad @gtjoseph
app_followme: fix issue with enable_callee_prompt=no (#88)
a8ea16c 
* app_followme: fix issue with enable_callee_prompt=no

If the FollowMe option 'enable_callee_prompt' is set to 'no' then Asterisk
incorrectly sets a winner channel to the channel from which any control frame was read.

This fix sets the winner channel only to the answered channel.

Resolves: #87

ASTERISK-30326
gtjoseph pushed a commit that referenced this pull request Jun 5, 2023
@alex2grad @gtjoseph
app_followme: fix issue with enable_callee_prompt=no (#88)
591351d 
* app_followme: fix issue with enable_callee_prompt=no

If the FollowMe option 'enable_callee_prompt' is set to 'no' then Asterisk
incorrectly sets a winner channel to the channel from which any control frame was read.

This fix sets the winner channel only to the answered channel.

Resolves: #87

ASTERISK-30326
asterisk-org-access-app bot pushed a commit that referenced this pull request Jun 30, 2023
@alex2grad @asteriskteam
app_followme: fix issue with enable_callee_prompt=no (#88)
3fae7aa 
* app_followme: fix issue with enable_callee_prompt=no

If the FollowMe option 'enable_callee_prompt' is set to 'no' then Asterisk
incorrectly sets a winner channel to the channel from which any control frame was read.

This fix sets the winner channel only to the answered channel.

Resolves: #87

ASTERISK-30326

(cherry picked from commit 591351d)
asterisk-org-access-app bot pushed a commit that referenced this pull request Jun 30, 2023
@alex2grad @asteriskteam
app_followme: fix issue with enable_callee_prompt=no (#88)
830a273 
* app_followme: fix issue with enable_callee_prompt=no

If the FollowMe option 'enable_callee_prompt' is set to 'no' then Asterisk
incorrectly sets a winner channel to the channel from which any control frame was read.

This fix sets the winner channel only to the answered channel.

Resolves: #87

ASTERISK-30326

(cherry picked from commit 591351d)
asterisk-org-access-app bot pushed a commit that referenced this pull request Jun 30, 2023
@alex2grad @asteriskteam
app_followme: fix issue with enable_callee_prompt=no (#88)
298683a 
* app_followme: fix issue with enable_callee_prompt=no

If the FollowMe option 'enable_callee_prompt' is set to 'no' then Asterisk
incorrectly sets a winner channel to the channel from which any control frame was read.

This fix sets the winner channel only to the answered channel.

Resolves: #87

ASTERISK-30326

(cherry picked from commit 591351d)
asterisk-org-access-app bot pushed a commit that referenced this pull request Jun 30, 2023
@alex2grad @asteriskteam
app_followme: fix issue with enable_callee_prompt=no (#88)
fa19701 
* app_followme: fix issue with enable_callee_prompt=no

If the FollowMe option 'enable_callee_prompt' is set to 'no' then Asterisk
incorrectly sets a winner channel to the channel from which any control frame was read.

This fix sets the winner channel only to the answered channel.

Resolves: #87

ASTERISK-30326

(cherry picked from commit 591351d)
asterisk-org-access-app bot pushed a commit that referenced this pull request Jun 30, 2023
@alex2grad @asteriskteam
app_followme: fix issue with enable_callee_prompt=no (#88)
ba29d16 
* app_followme: fix issue with enable_callee_prompt=no

If the FollowMe option 'enable_callee_prompt' is set to 'no' then Asterisk
incorrectly sets a winner channel to the channel from which any control frame was read.

This fix sets the winner channel only to the answered channel.

Resolves: #87

ASTERISK-30326

(cherry picked from commit 591351d)
asterisk-org-access-app bot pushed a commit that referenced this pull request Jun 30, 2023
@alex2grad @asteriskteam
app_followme: fix issue with enable_callee_prompt=no (#88)
e0c3f6d 
* app_followme: fix issue with enable_callee_prompt=no

If the FollowMe option 'enable_callee_prompt' is set to 'no' then Asterisk
incorrectly sets a winner channel to the channel from which any control frame was read.

This fix sets the winner channel only to the answered channel.

Resolves: #87

ASTERISK-30326

(cherry picked from commit a8ea16c)
asterisk-org-access-app bot pushed a commit that referenced this pull request Jul 10, 2023
@alex2grad @asteriskteam
app_followme: fix issue with enable_callee_prompt=no (#88)
cf2f3a1 
* app_followme: fix issue with enable_callee_prompt=no

If the FollowMe option 'enable_callee_prompt' is set to 'no' then Asterisk
incorrectly sets a winner channel to the channel from which any control frame was read.

This fix sets the winner channel only to the answered channel.

Resolves: #87

ASTERISK-30326

(cherry picked from commit 591351d)
asterisk-org-access-app bot pushed a commit that referenced this pull request Jul 10, 2023
@alex2grad @asteriskteam
app_followme: fix issue with enable_callee_prompt=no (#88)
319da11 
* app_followme: fix issue with enable_callee_prompt=no

If the FollowMe option 'enable_callee_prompt' is set to 'no' then Asterisk
incorrectly sets a winner channel to the channel from which any control frame was read.

This fix sets the winner channel only to the answered channel.

Resolves: #87

ASTERISK-30326

(cherry picked from commit a8ea16c)
@MikeNaso MikeNaso mentioned this pull request Aug 5, 2023
Closed
@intellasoft intellasoft mentioned this pull request Sep 9, 2023
Closed
@mehmet-ozgul mehmet-ozgul mentioned this pull request May 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InterLinked1 InterLinked1 InterLinked1 requested changes

@jcolp jcolp jcolp approved these changes

Assignees
No one assigned
Labels
cherry-pick-checks-passed Cherry-Pick checks passed cherry-pick-gates-failed Cherry-Pick gates failed test-checks-passed test-gates-passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: app_followme: Setting enable_callee_prompt=no breaks timeout
4 participants
@alex2grad @InterLinked1 @jcolp @gtjoseph