Use ruff format (alpha) command for formatting
#230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Sep 1, 2023
| ruff ./ruff_lsp ./tests | ||
| black --check ./ruff_lsp ./tests | ||
| ruff check ./ruff_lsp ./tests | ||
| ruff format --check ./ruff_lsp ./tests |
There was a problem hiding this comment.
The allure of the unified ruff check...
MichaReiser
approved these changes
Sep 1, 2023
|
🥳 |
charliermarsh
force-pushed
the
charlie/format
branch
2 times, most recently
from
c376978
to
8f08ab9
Compare
charliermarsh
force-pushed
the
charlie/format
branch
from
8f08ab9
to
ced53ca
Compare
charliermarsh
commented
Sep 1, 2023
| @@ -0,0 +1 @@ | |||
| * text=auto eol=lf | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR transitions the LSP to use Ruff's formatter via the (alpha)
ruff formatcommand. It's not yet recommended for production use, but it's more than ready for us to use it internally :)