Avoid D403 if first char cannot be uppercased (#4283)

astral-sh · May 8, 2023 · 4ac5065 · 4ac5065
1 parent cd41de2
commit 4ac5065
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/crates/ruff/resources/test/fixtures/pydocstyle/D403.py b/crates/ruff/resources/test/fixtures/pydocstyle/D403.py
@@ -13,3 +13,6 @@ def another_function():
 
 def utf8_function():
     """éste docstring is capitalized."""
+
+def uppercase_char_not_possible():
+    """'args' is not capitalized."""
diff --git a/crates/ruff/src/rules/pydocstyle/rules/capitalized.rs b/crates/ruff/src/rules/pydocstyle/rules/capitalized.rs
@@ -59,6 +59,15 @@ pub fn capitalized(checker: &mut Checker, docstring: &Docstring) {
     if first_char.is_uppercase() {
         return;
     };
+    if first_char
+        .to_uppercase()
+        .next()
+        .map_or(false, |uppercase_first_char| {
+            uppercase_first_char == first_char
+        })
+    {
+        return;
+    }
 
     let capitalized_word = first_char.to_uppercase().to_string() + first_word_chars.as_str();