Skip to content

Commit

Permalink
chore: Remove default_members from Cargo.toml (#3006)
Browse files Browse the repository at this point in the history
This PR removes the `default_members` from the workspace configuration. 

## Why

I'm not familiar with the motivation for why the `default_members` setting was added initially, and I do not object to keeping it. I'll explain my motivation for removing it below. 

My main reason for removing the `default_members` override is that new contributors may not know that `cargo test`, `cargo build`, and other commands only run on a subset of crates. They may then be surprised that their PRs are failing in CI, but everything works locally. 

My guess why `default_members` was added is to speed up the development workflow. That's fair, but I question the value because `ruff` is the heaviest crate to build.
  • Loading branch information
MichaReiser committed Feb 19, 2023
1 parent cfa6883 commit a7c5336
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
[workspace]
members = ["crates/*"]
default-members = ["crates/ruff", "crates/ruff_cli"]

[workspace.dependencies]
anyhow = { version = "1.0.66" }
Expand Down

0 comments on commit a7c5336

Please sign in to comment.