chore: Remove default_members from Cargo.toml
#3006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Agreed.) |
|
Oh, I guess the reason this was present was to make |
|
Not sure if there's a way to fix that, or if we need to update the docs anywhere. |
JonathanPlasse
added a commit
to JonathanPlasse/ruff
that referenced
this pull request
Feb 19, 2023
Add --force-exclude, --exit-non-zero-on-fix to ruff pre-commit hook
JonathanPlasse
added a commit
to JonathanPlasse/ruff
that referenced
this pull request
Feb 19, 2023
Add --force-exclude, --exit-non-zero-on-fix to ruff pre-commit hook
charliermarsh
pushed a commit
that referenced
this pull request
Feb 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
default_membersfrom the workspace configuration.Why
I'm not familiar with the motivation for why the
default_memberssetting was added initially, and I do not object to keeping it. I'll explain my motivation for removing it below.My main reason for removing the
default_membersoverride is that new contributors may not know thatcargo test,cargo build, and other commands only run on a subset of crates. They may then be surprised that their PRs are failing in CI, but everything works locally.My guess why
default_memberswas added is to speed up the development workflow. That's fair, but I question the value becauseruffis the heaviest crate to build.