Skip to content

Commit

Permalink
Add ability to generate snapshot tests on code snippets (#4714)
Browse files Browse the repository at this point in the history
  • Loading branch information
@charliermarsh @konstin
charliermarsh authored and konstin committed Jun 13, 2023
1 parent 6afee4a commit ae8ec55
Show file tree
Hide file tree
Showing 42 changed files with 516 additions and 161 deletions.
370 changes: 225 additions & 145 deletions crates/ruff/src/rules/pandas_vet/mod.rs
View file

Large diffs are not rendered by default.

20 changes: 20 additions & 0 deletions crates/ruff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD002_fail.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---
<filename>:4:23: PD002 [*] `inplace=True` should be avoided; it has inconsistent behavior
|
4 | import pandas as pd
5 | x = pd.DataFrame()
6 | x.drop(["a"], axis=1, inplace=True)
| ^^^^^^^^^^^^ PD002
|
= help: Assign to variable; remove `inplace` arg

ℹ Suggested fix
1 1 |
2 2 | import pandas as pd
3 3 | x = pd.DataFrame()
4 |-x.drop(["a"], axis=1, inplace=True)
4 |+x = x.drop(["a"], axis=1)


4 changes: 4 additions & 0 deletions crates/ruff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD002_pass.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

4 changes: 4 additions & 0 deletions .../rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD003_allows_other_calls.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

11 changes: 11 additions & 0 deletions crates/ruff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD003_fail.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---
<filename>:3:9: PD003 `.isna` is preferred to `.isnull`; functionality is equivalent
|
3 | import pandas as pd
4 | nulls = pd.isnull(val)
| ^^^^^^^^^ PD003
|


4 changes: 4 additions & 0 deletions crates/ruff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD003_pass.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

11 changes: 11 additions & 0 deletions crates/ruff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD004_fail.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---
<filename>:3:13: PD004 `.notna` is preferred to `.notnull`; functionality is equivalent
|
3 | import pandas as pd
4 | not_nulls = pd.notnull(val)
| ^^^^^^^^^^ PD004
|


4 changes: 4 additions & 0 deletions crates/ruff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD004_pass.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

12 changes: 12 additions & 0 deletions crates/ruff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD007_fail.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---
<filename>:4:5: PD007 `.ix` is deprecated; use more explicit `.loc` or `.iloc`
|
4 | import pandas as pd
5 | x = pd.DataFrame()
6 | y = x.ix[[0, 2], "A"]
| ^^^^^^^^^^^^^^^^^ PD007
|


4 changes: 4 additions & 0 deletions .../ruff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD007_pass_iloc.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

4 changes: 4 additions & 0 deletions ...s/ruff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD007_pass_loc.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

12 changes: 12 additions & 0 deletions crates/ruff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD008_fail.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---
<filename>:4:9: PD008 Use `.loc` instead of `.at`. If speed is important, use NumPy.
|
4 | import pandas as pd
5 | x = pd.DataFrame()
6 | index = x.at[:, ["B", "A"]]
| ^^^^^^^^^^^^^^^^^^^ PD008
|


4 changes: 4 additions & 0 deletions crates/ruff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD008_pass.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

4 changes: 4 additions & 0 deletions ...ff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD008_pass_on_attr.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

12 changes: 12 additions & 0 deletions crates/ruff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD009_fail.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---
<filename>:4:9: PD009 Use `.iloc` instead of `.iat`. If speed is important, use NumPy.
|
4 | import pandas as pd
5 | x = pd.DataFrame()
6 | index = x.iat[:, 1:3]
| ^^^^^^^^^^^^^ PD009
|


4 changes: 4 additions & 0 deletions crates/ruff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD009_pass.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

14 changes: 14 additions & 0 deletions ...ruff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD010_fail_pivot.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---
<filename>:4:9: PD010 `.pivot_table` is preferred to `.pivot` or `.unstack`; provides same functionality
|
4 | import pandas as pd
5 | x = pd.DataFrame()
6 | table = pd.pivot(
| ^^^^^^^^ PD010
7 | x,
8 | index="foo",
|


4 changes: 4 additions & 0 deletions crates/ruff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD010_pass.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

12 changes: 12 additions & 0 deletions ...uff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD011_fail_values.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---
<filename>:4:10: PD011 Use `.to_numpy()` instead of `.values`
|
4 | import pandas as pd
5 | x = pd.DataFrame()
6 | result = x.values
| ^^^^^^^^ PD011
|


4 changes: 4 additions & 0 deletions ...ruff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD011_pass_array.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

4 changes: 4 additions & 0 deletions .../src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD011_pass_node_name.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

4 changes: 4 additions & 0 deletions ...f/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD011_pass_to_array.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

4 changes: 4 additions & 0 deletions ...rc/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD011_pass_values_call.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

4 changes: 4 additions & 0 deletions ...rc/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD011_pass_values_dict.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

4 changes: 4 additions & 0 deletions .../rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD011_pass_values_import.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

4 changes: 4 additions & 0 deletions ...rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD011_pass_values_unbound.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

11 changes: 11 additions & 0 deletions ...src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD012_fail_read_table.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---
<filename>:3:13: PD012 `.read_csv` is preferred to `.read_table`; provides same functionality
|
3 | import pandas as pd
4 | employees = pd.read_table(input_file)
| ^^^^^^^^^^^^^ PD012
|


4 changes: 4 additions & 0 deletions .../src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD012_node_Name_pass.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

4 changes: 4 additions & 0 deletions ...f/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD012_pass_read_csv.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

12 changes: 12 additions & 0 deletions ...ruff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD013_fail_stack.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---
<filename>:4:5: PD013 `.melt` is preferred to `.stack`; provides same functionality
|
4 | import pandas as pd
5 | x = pd.DataFrame()
6 | y = x.stack(level=-1, dropna=True)
| ^^^^^^^ PD013
|


4 changes: 4 additions & 0 deletions crates/ruff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD013_pass.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

4 changes: 4 additions & 0 deletions ...ruff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD013_pass_numpy.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

4 changes: 4 additions & 0 deletions ...ff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD013_pass_unbound.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

12 changes: 12 additions & 0 deletions ...ndas_vet/snapshots/ruff__rules__pandas_vet__tests__PD015_fail_merge_on_pandas_object.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---
<filename>:5:1: PD015 Use `.merge` method instead of `pd.merge` function. They have equivalent functionality.
|
5 | x = pd.DataFrame()
6 | y = pd.DataFrame()
7 | pd.merge(x, y)
| ^^^^^^^^ PD015
|


4 changes: 4 additions & 0 deletions ...s/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD015_pass_merge_on_dataframe.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

4 changes: 4 additions & 0 deletions ...ots/ruff__rules__pandas_vet__tests__PD015_pass_merge_on_dataframe_with_multiple_args.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

4 changes: 4 additions & 0 deletions ...es/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD015_pass_other_pd_function.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

11 changes: 11 additions & 0 deletions ...uff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD901_fail_df_var.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---
<filename>:3:1: PD901 `df` is a bad variable name. Be kinder to your future self.
|
3 | import pandas as pd
4 | df = pd.DataFrame()
| ^^ PD901
|


4 changes: 4 additions & 0 deletions ...f/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD901_pass_df_param.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

4 changes: 4 additions & 0 deletions ...uff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD901_pass_non_df.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

4 changes: 4 additions & 0 deletions ...ff/src/rules/pandas_vet/snapshots/ruff__rules__pandas_vet__tests__PD901_pass_part_df.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
source: crates/ruff/src/rules/pandas_vet/mod.rs
---

Loading

0 comments on commit ae8ec55

Please sign in to comment.