Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERA001 false negative #3525

Closed
JonathanPlasse opened this issue Mar 14, 2023 · 4 comments
Closed

ERA001 false negative #3525

JonathanPlasse opened this issue Mar 14, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@JonathanPlasse
Copy link
Contributor

JonathanPlasse commented Mar 14, 2023

# if severity != logSeverity.DEBUG:
#    add_log(context, str(x), severity)

# with keyboard.Events() as events:
#     # Block for as much as possible
#     event = events.get(1e6)
#     if event.key == keyboard.KeyCode.from_char('q'):
#         print("goodbye")
#         raise KeyboardInterrupt
#     if event.key == keyboard.KeyCode.from_char('r'):
#         print("reloading servers...")
#         return

become

# if severity != logSeverity.DEBUG:

# with keyboard.Events() as events:
#     # Block for as much as possible
#     if event.key == keyboard.KeyCode.from_char('q'):
#         raise KeyboardInterrupt
#     if event.key == keyboard.KeyCode.from_char('r'):

The upstream eradicate does not fix it either.

@charliermarsh charliermarsh added the bug Something isn't working label Mar 14, 2023
@charliermarsh
Copy link
Member

Lots of spooky regex in there...

@charliermarsh
Copy link
Member

I'm gonna merge with #3525.

@charliermarsh charliermarsh closed this as not planned Won't fix, can't repro, duplicate, stale Jun 13, 2023
@calumy
Copy link
Contributor

calumy commented Jun 13, 2023

I'm gonna merge with #3525.

This might be a typo as it is merging with itself.

@charliermarsh
Copy link
Member

Thanks, I meant #4845.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants