Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support flake8-fixme #3859

Closed
finswimmer opened this issue Apr 3, 2023 · 5 comments · Fixed by #4681
Closed

support flake8-fixme #3859

finswimmer opened this issue Apr 3, 2023 · 5 comments · Fixed by #4681
Assignees
Labels
plugin Implementing a known but unsupported plugin

Comments

@finswimmer
Copy link

Hey,

until know I could find rules for all my flake8 plugins or at least a feature request to support those.

The only one I'm missing is flake8-fixme.

Would be great to see this supported :)

fin swimmer

@charliermarsh charliermarsh added the plugin Implementing a known but unsupported plugin label Apr 3, 2023
@edgarrmondragon
Copy link
Contributor

Maybe https://github.com/orsinium-labs/flake8-todos would be preferred?

It seems more comprehensive

  • T001: use TODO instead of FIXME (or BUG) for consistency.
  • T002: add author into TODO (motivation).
  • T003: add link on issue into TODO.
  • T004: missed colon in TODO.
  • T005: missed text in TODO.
  • T006: write TODO instead of ToDo (use upper case).
  • T007: missed space after colon in TODO.

@finswimmer
Copy link
Author

finswimmer commented Apr 3, 2023

Maybe https://github.com/orsinium-labs/flake8-todos would be preferred?

The purpose if flake8-todos seems to another one, compared to flake8-fixme. The later one ensures that there are no TODOs, FIXME etc. in the code base. And that's the functionality I like to have in ruff 😃

@edgarrmondragon
Copy link
Contributor

You're right, the two plugins address different problems! I'll create a separate issue for my suggestion.

@evanrittenhouse
Copy link
Contributor

@charliermarsh can you please assign this to me? Once #3921 lands, I'll be able to refactor some of the TODO detection out to a common location - when that's done, it'll be pretty trivial to clear this as well.

@evanrittenhouse
Copy link
Contributor

The fix I have in mind depends on this PR being merged so I can rebase on top of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin Implementing a known but unsupported plugin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants