Implement flake8_todos
#3921
Merged
Implement flake8_todos
#3921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Check ResultsEcosystem✅ ecosystem check detected no changes. BenchmarkLinuxWindows |
evanrittenhouse
force-pushed
the
flake8_todo
branch
from
73d4c59
to
e3fbd06
Compare
evanrittenhouse
commented
Apr 9, 2023
evanrittenhouse
commented
Apr 9, 2023
dhruvmanila
reviewed
Apr 9, 2023
MichaReiser
reviewed
Apr 11, 2023
MichaReiser
reviewed
Apr 11, 2023
evanrittenhouse
force-pushed
the
flake8_todo
branch
from
d8d1a79
to
796c32e
Compare
evanrittenhouse
changed the title
|
@charliermarsh Would you prefer I implement TDO003 in this PR as well, or do we allow partial implementation of plugins? |
|
Partial is cool, I just haven't had time to sit down and dig in on this one yet. |
|
Sorry, didn't mean to rush you at all! Just the first time I've tried implementing a plugin, so wasn't sure how we handle that. Please take your time |
evanrittenhouse
commented
Apr 15, 2023
evanrittenhouse
force-pushed
the
flake8_todo
branch
from
717f141
to
fbb6062
Compare
|
No idea why these errors are happening - will take a closer look in a bit E: had to bump the ruleset |
evanrittenhouse
changed the title
Closed
evanrittenhouse
force-pushed
the
flake8_todo
branch
from
abae0d7
to
b644d61
Compare
MichaReiser
reviewed
Apr 23, 2023
|
Re-marking as draft to fix an edge case and clean up the code a little bit |
evanrittenhouse
force-pushed
the
flake8_todo
branch
2 times, most recently
from
4554c0c
to
c85e07a
Compare
evanrittenhouse
commented
Apr 25, 2023
|
Sorry for the false starts. I believe this is good to go now |
MichaReiser
approved these changes
May 1, 2023
...flake8_todo/snapshots/ruff__rules__flake8_todo__tests__missing-author-in-todo_TDO002.py.snap
Outdated
Show resolved
Hide resolved
...flake8_todo/snapshots/ruff__rules__flake8_todo__tests__missing-author-in-todo_TDO002.py.snap
Outdated
Show resolved
Hide resolved
.../flake8_todo/snapshots/ruff__rules__flake8_todo__tests__missing-colon-in-todo_TDO004.py.snap
Outdated
Show resolved
Hide resolved
...s/flake8_todo/snapshots/ruff__rules__flake8_todo__tests__missing-link-in-todo_TDO003.py.snap
Outdated
Show resolved
Hide resolved
.../snapshots/ruff__rules__flake8_todo__tests__missing-space-after-colon-in-todo_TDO007.py.snap
Outdated
Show resolved
Hide resolved
evanrittenhouse
force-pushed
the
flake8_todo
branch
from
36fbb57
to
dfee2f0
Compare
|
I'm not super sure why those tests are failing - it seems like they're referencing the old snapshots which no longer exist, but I already removed them so I'm not even really sure why they're being referenced |
|
These snapshots must be deleted. |
|
You can do this automatically by running cargo insta test --all --all-features --delete-unreferenced-snapshots |
|
Gonna do one pass over the docs then merge. |
|
There is one bug here, whereby links aren't detected in multiline comments, i.e., this is a false positive: # TODO: here's a TODO on the last line with no link
# Here's more content.
# TDO-3870 |
renovate bot
added a commit
to ixm-one/pytest-cmake-presets
that referenced
this pull request
May 19, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `^0.0.267` -> `^0.0.269` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.269`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.269) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.267...v0.0.269) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed (This is a rerelease of `v0.0.268`, which didn't make it to PyPI due to user error. As such, the release notes are copied below.) ##### `pycodestyle` This release includes optimized implementations of a large portion of `pycodestyle`, for those that use Ruff without an autoformatter. In this initial release, the rules are being introduced under a "nursery" flag, which requires that users explicitly select them (e.g., `select = ["E111"]`); in other words, these rules are not yet enabled via `select = ["E"]`. If you're interested in testing the `pycodestyle` rules, you can enable them via: ```toml select = [ "E111", "E112", "E113", "E114", "E115", "E116", "E117", "E201", "E202", "E203", "E211", "E221", "E222", "E223", "E224", "E225", "E226", "E227", "E228", "E231", "E251", "E252", "E261", "E262", "E265", "E266", "E271", "E272", "E273", "E274", "E275", ] ``` These rules will be included as part of the `E` category in a future release. ##### Breaking Changes - \[`pyupgrade`] Remove `keep-runtime-typing` setting by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4427 ##### Rules - \[`pylint`] Add `duplicate-bases` rule by [@​alonme](https://togithub.com/alonme) in [astral-sh/ruff#4411 - \[`pylint`] Fix `PLW3301` auto-fix with generators by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4412 - \[`flake8-async`] Implement flake8-async plugin by [@​qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4432 - \[`pyupgrade`] Enable automatic rewrites of `typing.Deque` and `typing.DefaultDict` by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4420 - \[`flake8-pyi`] Implement `unannotated-assignment-in-stub` (`PY052`) by [@​sladyn98](https://togithub.com/sladyn98) in [astral-sh/ruff#4293 - \[`tryceratops`] Implement TRY302 - `raise` after `except` by [@​john-h-k](https://togithub.com/john-h-k) in [astral-sh/ruff#4461 - \[`flake8-bandit`] Improve SQL injection detection logic (`S608`) by [@​scop](https://togithub.com/scop) in [astral-sh/ruff#4499 - \[`flake8-todos`] Implement `flake8_todos` by [@​evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#3921 - \[`flake8-future-annotations`] Implement `flake8-future-annotations` FA100 by [@​TylerYep](https://togithub.com/TylerYep) in [astral-sh/ruff#3979 - Enable `pycodestyle` rules by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3689 - Enable `pycodestyle` rules under new "nursery" category by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4407 ##### Settings - Merge subsettings when extending configurations by [@​bendoerry](https://togithub.com/bendoerry) in [astral-sh/ruff#4431 ##### Bug Fixes - Extend multi-line noqa directives to start-of-line by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4490 - Fix scoping of comprehensions within classes by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4494 - Enable autofix for split-assertions at top level by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4405 - Ignore ANN401 for overridden methods by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4409 - Fix `RUF010` autofix within f-strings by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4423 - Update C419 to be a suggested fix by [@​madkinsz](https://togithub.com/madkinsz) in [astral-sh/ruff#4424 - Fix expected-indentation errors with end-of-line comments by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4438 - Emit non-logical newlines for "empty" lines by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4444 - Avoid emitting empty logical lines by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4452 - Avoid flagging missing whitespace for decorators by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4454 - Remove special-casing for whitespace-around-@​ by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4458 - Avoid triggering `pd#at` and friends on non-subscripts by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4474 - Include precise tokens for extraneous-whitespace diagnostics by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4471 - Allow shebang comments at start-of-file by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4473 - Bring pycodestyle rules into full compatibility (on SciPy) by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4472 - Invert quote-style when generating code within f-strings by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4487 - Fix COM812 false positive in string subscript by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4493 - Overhaul sdist handling by [@​konstin](https://togithub.com/konstin) in [astral-sh/ruff#4439 #### New Contributors - [@​TylerYep](https://togithub.com/TylerYep) made their first contribution in [astral-sh/ruff#3979 - [@​yanksyoon](https://togithub.com/yanksyoon) made their first contribution in [astral-sh/ruff#4428 - [@​bendoerry](https://togithub.com/bendoerry) made their first contribution in [astral-sh/ruff#4431 - [@​qdegraaf](https://togithub.com/qdegraaf) made their first contribution in [astral-sh/ruff#4432 - [@​jameslamb](https://togithub.com/jameslamb) made their first contribution in [astral-sh/ruff#4446 - [@​john-h-k](https://togithub.com/john-h-k) made their first contribution in [astral-sh/ruff#4461 **Full Changelog**: astral-sh/ruff@v0.0.267...v0.0.269 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS45NS4xIiwidXBkYXRlZEluVmVyIjoiMzUuOTUuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
renovate bot
added a commit
to allenporter/pyrainbird
that referenced
this pull request
May 20, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `==0.0.267` -> `==0.0.269` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.269`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.269) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.267...v0.0.269) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed (This is a rerelease of `v0.0.268`, which didn't make it to PyPI due to user error. As such, the release notes are copied below.) ##### `pycodestyle` This release includes optimized implementations of a large portion of `pycodestyle`, for those that use Ruff without an autoformatter. In this initial release, the rules are being introduced under a "nursery" flag, which requires that users explicitly select them (e.g., `select = ["E111"]`); in other words, these rules are not yet enabled via `select = ["E"]`. If you're interested in testing the `pycodestyle` rules, you can enable them via: ```toml select = [ "E111", "E112", "E113", "E114", "E115", "E116", "E117", "E201", "E202", "E203", "E211", "E221", "E222", "E223", "E224", "E225", "E226", "E227", "E228", "E231", "E251", "E252", "E261", "E262", "E265", "E266", "E271", "E272", "E273", "E274", "E275", ] ``` These rules will be included as part of the `E` category in a future release. ##### Breaking Changes - \[`pyupgrade`] Remove `keep-runtime-typing` setting by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4427 ##### Rules - \[`pylint`] Add `duplicate-bases` rule by [@​alonme](https://togithub.com/alonme) in [astral-sh/ruff#4411 - \[`pylint`] Fix `PLW3301` auto-fix with generators by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4412 - \[`flake8-async`] Implement flake8-async plugin by [@​qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4432 - \[`pyupgrade`] Enable automatic rewrites of `typing.Deque` and `typing.DefaultDict` by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4420 - \[`flake8-pyi`] Implement `unannotated-assignment-in-stub` (`PY052`) by [@​sladyn98](https://togithub.com/sladyn98) in [astral-sh/ruff#4293 - \[`tryceratops`] Implement TRY302 - `raise` after `except` by [@​john-h-k](https://togithub.com/john-h-k) in [astral-sh/ruff#4461 - \[`flake8-bandit`] Improve SQL injection detection logic (`S608`) by [@​scop](https://togithub.com/scop) in [astral-sh/ruff#4499 - \[`flake8-todos`] Implement `flake8_todos` by [@​evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#3921 - \[`flake8-future-annotations`] Implement `flake8-future-annotations` FA100 by [@​TylerYep](https://togithub.com/TylerYep) in [astral-sh/ruff#3979 - Enable `pycodestyle` rules by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3689 - Enable `pycodestyle` rules under new "nursery" category by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4407 ##### Settings - Merge subsettings when extending configurations by [@​bendoerry](https://togithub.com/bendoerry) in [astral-sh/ruff#4431 ##### Bug Fixes - Extend multi-line noqa directives to start-of-line by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4490 - Fix scoping of comprehensions within classes by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4494 - Enable autofix for split-assertions at top level by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4405 - Ignore ANN401 for overridden methods by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4409 - Fix `RUF010` autofix within f-strings by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4423 - Update C419 to be a suggested fix by [@​madkinsz](https://togithub.com/madkinsz) in [astral-sh/ruff#4424 - Fix expected-indentation errors with end-of-line comments by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4438 - Emit non-logical newlines for "empty" lines by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4444 - Avoid emitting empty logical lines by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4452 - Avoid flagging missing whitespace for decorators by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4454 - Remove special-casing for whitespace-around-@​ by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4458 - Avoid triggering `pd#at` and friends on non-subscripts by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4474 - Include precise tokens for extraneous-whitespace diagnostics by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4471 - Allow shebang comments at start-of-file by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4473 - Bring pycodestyle rules into full compatibility (on SciPy) by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4472 - Invert quote-style when generating code within f-strings by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4487 - Fix COM812 false positive in string subscript by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4493 - Overhaul sdist handling by [@​konstin](https://togithub.com/konstin) in [astral-sh/ruff#4439 #### New Contributors - [@​TylerYep](https://togithub.com/TylerYep) made their first contribution in [astral-sh/ruff#3979 - [@​yanksyoon](https://togithub.com/yanksyoon) made their first contribution in [astral-sh/ruff#4428 - [@​bendoerry](https://togithub.com/bendoerry) made their first contribution in [astral-sh/ruff#4431 - [@​qdegraaf](https://togithub.com/qdegraaf) made their first contribution in [astral-sh/ruff#4432 - [@​jameslamb](https://togithub.com/jameslamb) made their first contribution in [astral-sh/ruff#4446 - [@​john-h-k](https://togithub.com/john-h-k) made their first contribution in [astral-sh/ruff#4461 **Full Changelog**: astral-sh/ruff@v0.0.267...v0.0.269 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/pyrainbird). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS45NS4xIiwidXBkYXRlZEluVmVyIjoiMzUuOTUuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
added a commit
to allenporter/flux-local
that referenced
this pull request
May 20, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) ([changelog](https://togithub.com/charliermarsh/ruff/releases)) | `==0.0.267` -> `==0.0.269` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.269`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.269) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.267...v0.0.269) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed (This is a rerelease of `v0.0.268`, which didn't make it to PyPI due to user error. As such, the release notes are copied below.) ##### `pycodestyle` This release includes optimized implementations of a large portion of `pycodestyle`, for those that use Ruff without an autoformatter. In this initial release, the rules are being introduced under a "nursery" flag, which requires that users explicitly select them (e.g., `select = ["E111"]`); in other words, these rules are not yet enabled via `select = ["E"]`. If you're interested in testing the `pycodestyle` rules, you can enable them via: ```toml select = [ "E111", "E112", "E113", "E114", "E115", "E116", "E117", "E201", "E202", "E203", "E211", "E221", "E222", "E223", "E224", "E225", "E226", "E227", "E228", "E231", "E251", "E252", "E261", "E262", "E265", "E266", "E271", "E272", "E273", "E274", "E275", ] ``` These rules will be included as part of the `E` category in a future release. ##### Breaking Changes - \[`pyupgrade`] Remove `keep-runtime-typing` setting by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4427 ##### Rules - \[`pylint`] Add `duplicate-bases` rule by [@​alonme](https://togithub.com/alonme) in [astral-sh/ruff#4411 - \[`pylint`] Fix `PLW3301` auto-fix with generators by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4412 - \[`flake8-async`] Implement flake8-async plugin by [@​qdegraaf](https://togithub.com/qdegraaf) in [astral-sh/ruff#4432 - \[`pyupgrade`] Enable automatic rewrites of `typing.Deque` and `typing.DefaultDict` by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4420 - \[`flake8-pyi`] Implement `unannotated-assignment-in-stub` (`PY052`) by [@​sladyn98](https://togithub.com/sladyn98) in [astral-sh/ruff#4293 - \[`tryceratops`] Implement TRY302 - `raise` after `except` by [@​john-h-k](https://togithub.com/john-h-k) in [astral-sh/ruff#4461 - \[`flake8-bandit`] Improve SQL injection detection logic (`S608`) by [@​scop](https://togithub.com/scop) in [astral-sh/ruff#4499 - \[`flake8-todos`] Implement `flake8_todos` by [@​evanrittenhouse](https://togithub.com/evanrittenhouse) in [astral-sh/ruff#3921 - \[`flake8-future-annotations`] Implement `flake8-future-annotations` FA100 by [@​TylerYep](https://togithub.com/TylerYep) in [astral-sh/ruff#3979 - Enable `pycodestyle` rules by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3689 - Enable `pycodestyle` rules under new "nursery" category by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4407 ##### Settings - Merge subsettings when extending configurations by [@​bendoerry](https://togithub.com/bendoerry) in [astral-sh/ruff#4431 ##### Bug Fixes - Extend multi-line noqa directives to start-of-line by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4490 - Fix scoping of comprehensions within classes by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4494 - Enable autofix for split-assertions at top level by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4405 - Ignore ANN401 for overridden methods by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4409 - Fix `RUF010` autofix within f-strings by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4423 - Update C419 to be a suggested fix by [@​madkinsz](https://togithub.com/madkinsz) in [astral-sh/ruff#4424 - Fix expected-indentation errors with end-of-line comments by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4438 - Emit non-logical newlines for "empty" lines by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4444 - Avoid emitting empty logical lines by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4452 - Avoid flagging missing whitespace for decorators by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4454 - Remove special-casing for whitespace-around-@​ by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4458 - Avoid triggering `pd#at` and friends on non-subscripts by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4474 - Include precise tokens for extraneous-whitespace diagnostics by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4471 - Allow shebang comments at start-of-file by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4473 - Bring pycodestyle rules into full compatibility (on SciPy) by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4472 - Invert quote-style when generating code within f-strings by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#4487 - Fix COM812 false positive in string subscript by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#4493 - Overhaul sdist handling by [@​konstin](https://togithub.com/konstin) in [astral-sh/ruff#4439 #### New Contributors - [@​TylerYep](https://togithub.com/TylerYep) made their first contribution in [astral-sh/ruff#3979 - [@​yanksyoon](https://togithub.com/yanksyoon) made their first contribution in [astral-sh/ruff#4428 - [@​bendoerry](https://togithub.com/bendoerry) made their first contribution in [astral-sh/ruff#4431 - [@​qdegraaf](https://togithub.com/qdegraaf) made their first contribution in [astral-sh/ruff#4432 - [@​jameslamb](https://togithub.com/jameslamb) made their first contribution in [astral-sh/ruff#4446 - [@​john-h-k](https://togithub.com/john-h-k) made their first contribution in [astral-sh/ruff#4461 **Full Changelog**: astral-sh/ruff@v0.0.267...v0.0.269 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/flux-local). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS45Ni4zIiwidXBkYXRlZEluVmVyIjoiMzUuOTYuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes #3870
Will be able to easily clear #3859 when this lands as well.