Categorise fixes as safe or maybe_incorrect

[MichaReiser]

Part of #4181 and depends on #4183

#4183 introduced the new Fix::safe and Fix::maybe_incorrect constructors. The goal of this task is to go through all usages of Fix::unspecified, Fix::unspecified_edits, Diagnostic::try_set_from_edit, and Diagnostic::set_from_edit and replace them with Fix::safe* or Fix::maybe_incorrect depending on whether the fix is safe or unsafe (may introduce semantic changes).

I recommend creating individual PRs per rule because it makes discussing the safety properties of individual fixes easier.

[zanieb]

Note the constructor names have changed:

• Fix::safe -> Fix::automatic
• Fix::maybe_incorrect -> Fix::suggested or Fix::manual
• Diagnostic::try_set_from_edit -> Diagnostic::try_set_fix_from_edit

See #4303 and #4275 for details.

[sladyn98]

@MichaReiser I was going through the codebase and it seems all of the code has been migrated, is there something that I am missing with this migration.

[MichaReiser]

@MichaReiser I was going through the codebase and it seems all of the code has been migrated, is there something that I am missing with this migration.

You can search for usages of Fix::unspecified or Fix::unspecified_edits to find rules that need to be migrated

https://github.com/charliermarsh/ruff/blob/c6e5fed6587c95839a814ee8dfa845b465351229/crates/ruff_diagnostics/src/fix.rs#L40-L59

[evanrittenhouse]

#5119 depends on all Fix::unspecified instances being refactored to an applicable (pun intended :P ) Applicability. Currently, ripgrep says there are occurrences in:

1. flake8_commas: fixed in Add Applicability to flake8_comma fixes #5127
2. flake8_logging_format: fixed in Add Applicability to flake8_logging_format fixes #5129
3. flake8_pytest_style:
4. flake8_quotes: fixed in Add Applicability to flake8_quotes fixes #5130
5. flake8_simpilfy:
6. flake8_tidy_imports:
7. flynt
8. isort
9. pandas_vet
10. pycodestyle
11. pydocstyle
12. pyflakes
13. pylint
14. pyupgrade

An up-to-date list can be found in the description for #5119.

[evanrittenhouse]

@charliermarsh I believe there are two more linters that need to be completed - pycodestyle and flake8_pytest_style. May want to reopen until those are done, though I plan on completing them by the end of the weekend.

[charliermarsh]

Oh sorry, did this get closed accidentally by a PR? Anyway, reopened!

[zanieb]

I think this is done now! @evanrittenhouse let me know if that's wrong — thanks for taking all those on!

[evanrittenhouse]

Yup! On to the fun part ;)

[MichaReiser]

Wohoo. Nice work @evanrittenhouse.