Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Applicability to isort #5161

Merged
merged 2 commits into from
Jun 17, 2023

Conversation

evanrittenhouse
Copy link
Contributor

@evanrittenhouse evanrittenhouse commented Jun 17, 2023

Summary

Fixes some of #4184.

Test Plan

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      6.1±0.14ms     6.6 MB/sec    1.02      6.3±0.29ms     6.5 MB/sec
formatter/numpy/ctypeslib.py               1.00  1288.5±41.04µs    12.9 MB/sec    1.05  1350.6±77.28µs    12.3 MB/sec
formatter/numpy/globals.py                 1.00    126.2±6.51µs    23.4 MB/sec    1.09   137.9±13.39µs    21.4 MB/sec
formatter/pydantic/types.py                1.00      2.5±0.07ms    10.1 MB/sec    1.11      2.8±0.14ms     9.0 MB/sec
linter/all-rules/large/dataset.py          1.00     13.8±0.63ms     3.0 MB/sec    1.00     13.7±0.47ms     3.0 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.2±0.07ms     5.2 MB/sec    1.02      3.3±0.10ms     5.1 MB/sec
linter/all-rules/numpy/globals.py          1.00   460.1±37.04µs     6.4 MB/sec    1.00   458.8±32.75µs     6.4 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.0±0.36ms     4.2 MB/sec    1.01      6.1±0.36ms     4.2 MB/sec
linter/default-rules/large/dataset.py      1.00      6.5±0.16ms     6.2 MB/sec    1.01      6.6±0.16ms     6.2 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1422.8±45.55µs    11.7 MB/sec    1.09  1556.3±111.36µs    10.7 MB/sec
linter/default-rules/numpy/globals.py      1.00    164.6±7.08µs    17.9 MB/sec    1.07   175.5±13.11µs    16.8 MB/sec
linter/default-rules/pydantic/types.py     1.04      3.2±0.20ms     8.1 MB/sec    1.00      3.1±0.13ms     8.4 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      7.6±0.08ms     5.3 MB/sec    1.13      8.6±0.07ms     4.7 MB/sec
formatter/numpy/ctypeslib.py               1.00  1568.6±24.67µs    10.6 MB/sec    1.10  1728.5±20.38µs     9.6 MB/sec
formatter/numpy/globals.py                 1.00    151.9±3.18µs    19.4 MB/sec    1.09   164.8±12.10µs    17.9 MB/sec
formatter/pydantic/types.py                1.00      3.1±0.04ms     8.1 MB/sec    1.12      3.5±0.04ms     7.3 MB/sec
linter/all-rules/large/dataset.py          1.00     15.7±0.16ms     2.6 MB/sec    1.00     15.6±0.11ms     2.6 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      4.1±0.07ms     4.0 MB/sec    1.00      4.1±0.04ms     4.1 MB/sec
linter/all-rules/numpy/globals.py          1.00    490.7±6.51µs     6.0 MB/sec    1.00    490.3±8.24µs     6.0 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.9±0.06ms     3.7 MB/sec    1.00      6.9±0.06ms     3.7 MB/sec
linter/default-rules/large/dataset.py      1.00      8.1±0.04ms     5.0 MB/sec    1.01      8.2±0.05ms     5.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1735.4±15.22µs     9.6 MB/sec    1.00  1741.4±24.93µs     9.6 MB/sec
linter/default-rules/numpy/globals.py      1.00    199.6±6.44µs    14.8 MB/sec    1.00    199.6±2.60µs    14.8 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.7±0.04ms     6.9 MB/sec    1.01      3.7±0.03ms     6.9 MB/sec

@charliermarsh charliermarsh enabled auto-merge (squash) June 17, 2023 19:03
@charliermarsh charliermarsh merged commit 95448ba into astral-sh:main Jun 17, 2023
@evanrittenhouse evanrittenhouse deleted the applicability_isort branch June 17, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants